Update benchmark code

Author: friendlymatthew

datafusion/functions/benches/to_char.rs

@@ -64,10 +64,10 @@ fn generate_date32_array(rng: &mut ThreadRng) -> Date32Array {
     Date32Array::from(data)
 }
 
-const DATE_PATTERNS: [&'static str; 5] =
+const DATE_PATTERNS: [&str; 5] =
     ["%Y:%m:%d", "%d-%m-%Y", "%d%m%Y", "%Y%m%d", "%Y...%m...%d"];
 
-const DATETIME_PATTERNS: [&'static str; 8] = [
+const DATETIME_PATTERNS: [&str; 8] = [
     "%Y:%m:%d %H:%M%S",
     "%Y:%m:%d %_H:%M%S",
     "%Y:%m:%d %k:%M%S",
@@ -101,7 +101,7 @@ fn pick_date_and_date_time_mixed_pattern(rng: &mut ThreadRng) -> String {
 
 fn generate_pattern_array(
     rng: &mut ThreadRng,
-    mut pick_fn: impl FnMut(&mut ThreadRng) -> String,
+    pick_fn: impl Fn(&mut ThreadRng) -> String,
 ) -> StringArray {
     let mut data = Vec::with_capacity(1000);
 
@@ -125,7 +125,7 @@ fn generate_mixed_pattern_array(rng: &mut ThreadRng) -> StringArray {
 }
 
 fn criterion_benchmark(c: &mut Criterion) {
-    c.bench_function("to_char_array_array_date_only_patterns_1000", |b| {
+    c.bench_function("to_char_array_date_only_patterns_1000", |b| {
         let mut rng = rand::thread_rng();
         let data_arr = generate_date32_array(&mut rng);
         let batch_len = data_arr.len();
@@ -147,7 +147,7 @@ fn criterion_benchmark(c: &mut Criterion) {
         })
     });
 
-    c.bench_function("to_char_array_array_datetime_patterns_1000", |b| {
+    c.bench_function("to_char_array_datetime_patterns_1000", |b| {
         let mut rng = rand::thread_rng();
         let data_arr = generate_date32_array(&mut rng);
         let batch_len = data_arr.len();
@@ -169,7 +169,7 @@ fn criterion_benchmark(c: &mut Criterion) {
         })
     });
 
-    c.bench_function("to_char_array_array_mixed_patterns_1000", |b| {
+    c.bench_function("to_char_array_mixed_patterns_1000", |b| {
         let mut rng = rand::thread_rng();
         let data_arr = generate_date32_array(&mut rng);
         let batch_len = data_arr.len();
@@ -191,7 +191,7 @@ fn criterion_benchmark(c: &mut Criterion) {
         })
     });
 
-    c.bench_function("to_char_array_scalar_date_only_pattern_1000", |b| {
+    c.bench_function("to_char_scalar_date_only_pattern_1000", |b| {
         let mut rng = rand::thread_rng();
         let data_arr = generate_date32_array(&mut rng);
         let batch_len = data_arr.len();
@@ -212,7 +212,7 @@ fn criterion_benchmark(c: &mut Criterion) {
         })
     });
 
-    c.bench_function("to_char_array_scalar_datetime_pattern_1000", |b| {
+    c.bench_function("to_char_scalar_datetime_pattern_1000", |b| {
         let mut rng = rand::thread_rng();
         let data_arr = generate_date32_array(&mut rng);
         let batch_len = data_arr.len();
@@ -234,7 +234,7 @@ fn criterion_benchmark(c: &mut Criterion) {
         })
     });
 
-    c.bench_function("to_char_scalar_scalar_1000", |b| {
+    c.bench_function("to_char_scalar_1000", |b| {
         let mut rng = rand::thread_rng();
         let timestamp = "2026-07-08T09:10:11"
             .parse::<NaiveDateTime>()