Skip to content

Tsconfig migration fixes #16050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2019
Merged

Tsconfig migration fixes #16050

merged 2 commits into from
Nov 4, 2019

Conversation

alan-agius4
Copy link
Collaborator

See individual commits.

…*.d.ts`

This fixes warnings such as the below;
```
WARNING in /test-update/src/environments/environment.prod.ts is part of the TypeScript compilation but it's unused.
Add only entry points to the 'files' or 'include' properties in your tsconfig.
```

When the previous generated add was in VE.
expect(include).toEqual(['foo.ts']);
});

it(`should update include '**/*.ts' in apps tsConfig to '**/*.d.ts'`, async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This migration will cause projects that use the string format of loadChildren with broken compilations, because the lazy routes will no longer be part of the compilation.

That being said, we have already deprecated the string syntax and migrated these as part of the previous version 8 migration so it should be ok. If users have trouble with this we can provide instructions on how to add the lazy routes to the compilation for users that need to still use the string syntax.

@vikerman vikerman merged commit d13387d into angular:master Nov 4, 2019
@alan-agius4 alan-agius4 deleted the tsconfig-migration-2 branch November 4, 2019 21:47
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
4 participants