Storage buckets#41
Open
NilayYadav wants to merge 3 commits into
Open
Conversation
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| @@ -1,4 +1,4 @@ | |||
| package trainloop | |||
| package main | |||
Contributor
There was a problem hiding this comment.
The package declaration has been changed from package trainloop to package main. This change will break any existing code that imports this module as a library using the trainloop package name.
If this file is intended to be used as a library (which seems likely given its location in an SDK directory), it should remain as package trainloop. The package main declaration should only be used if this file is intended to be the entry point of a standalone executable.
Consider reverting this change to maintain backward compatibility with existing code that depends on this package.
Suggested change
| package main | |
| package trainloop |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storage buckets