-
Notifications
You must be signed in to change notification settings - Fork 597
Simplify the split() documentation by removing the join()s from the examples #18676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0f0cff9
to
66096a8
Compare
This looks much clearer and more consistent to me. One thing I would suggest is maybe leaving out all of the semicolons, since these are just showing the "output" of expressions and not what they'll do as a complete statement (which is nothing, in void context). |
66096a8
to
8e13820
Compare
ed6af31
to
fa33056
Compare
split() is a very basic function, and the documentation should be simple for novinces. The split() documentation contains a lot of join() in the examples which only serve to muddle the concepts. This replaces the join() in the example with output in comments
d955261
to
38a948b
Compare
Using split in this fashion is very similar to how | ||
L<C<qwE<sol>E<sol>>|/qwE<sol>STRINGE<sol>> works. | ||
|
||
However, this special treatment can be avoided by specifying |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't sound right. Two adjacent sentences each beginning with
However, this special treatment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch I'll tweak the wording.
…xamples (Perl#18676) * Remove join() from split() examples as it confuses the concepts split() is a very basic function, and the documentation should be simple for novinces. The split() documentation contains a lot of join() in the examples which only serve to muddle the concepts. This replaces the join() in the example with output in comments * Fix a double sentence per KHW
split() is a very basic function, and the documentation should be simple for novices to be able to understand. The split() documentation contains a lot of join() in the examples which only serve to muddle the concepts. This replaces the join() in the example with actual output behind a comment block