Skip to content

Fix incorrect delimator ";" used to separate proj_info().searchpath entries#1497

Merged
kbevers merged 1 commit into
OSGeo:masterfrom
nyalldawson:fix_searchpath_sep
Jun 4, 2019
Merged

Fix incorrect delimator ";" used to separate proj_info().searchpath entries#1497
kbevers merged 1 commit into
OSGeo:masterfrom
nyalldawson:fix_searchpath_sep

Conversation

@nyalldawson

Copy link
Copy Markdown
Contributor

... on non-windows platforms, should be ":", not ";"

@nyalldawson

Copy link
Copy Markdown
Contributor Author
Comment thread src/4D_api.cpp Outdated
entries on non-windows platforms, should be ":"
@nyalldawson nyalldawson force-pushed the fix_searchpath_sep branch from 32d66ea to a7a7651 Compare June 3, 2019 06:55
@rouault

rouault commented Jun 3, 2019

Copy link
Copy Markdown
Member

@kbevers Do you think we should change the behaviour or keep as it ? After all, the implementation and documentation are consistent currently.
It is true that if we do the analogy with PATH, semi-colon for Windows and colon for Unix are more common.
When looking at the code, I was confused by the fact that path_append() has a #ifdef WIN32 / #else to have a different separator, but it isn't actually used

@kbevers

kbevers commented Jun 3, 2019

Copy link
Copy Markdown
Member

Do you think we should change the behaviour or keep as it ? After all, the implementation and documentation are consistent currently.
It is true that if we do the analogy with PATH, semi-colon for Windows and colon for Unix are more common.

I think we should accept this PR. As you say, it conforms to normal practice. I believe this is also how we deal with delimeters when parsing PROJ_LIB, right?

When looking at the code, I was confused by the fact that path_append() has a #ifdef WIN32 / #else to have a different separator, but it isn't actually used

That is clearly a bug - delim should have been used in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants