refactor: after clean

Author: Mark24Code

lib/convert2ascii/video2ascii.rb

@@ -34,7 +34,6 @@ def initialize(**args)
       @color_block = args[:color_block] || false
 
       check_packages
-      regist_hooks
     end
 
     def generate(**args)
@@ -43,9 +42,7 @@ def generate(**args)
       @color = args[:color] || @color # full
       @color_block = args[:color_block] || @color_block
 
-      if File.directory? @tmpdir
-        FileUtils.remove_entry @tmpdir
-      end
+      remove_tmpdir
       Dir.mkdir(@tmpdir)
       @audio = get_audio_from_video(@tmpdir)
       screenshots_from_video(@tmpdir)
@@ -73,6 +70,8 @@ def save(output_dir)
 
       puts ""
       puts Rainbow("[info] save success!").green
+    ensure
+      after_clean
     end
 
     def order_frames_path
@@ -99,6 +98,12 @@ def play(**args)
       TerminalPlayer.new(**player_args).play
 
       return true
+    ensure
+      after_clean
+    end
+
+    def after_clean
+      remove_tmpdir
     end
 
     private
@@ -108,12 +113,10 @@ def check_packages
       CheckFFmpeg.new.check
     end
 
-    def regist_hooks
-      at_exit {
-        if @tmpdir
-          FileUtils.remove_entry @tmpdir
-        end
-      }
+    def remove_tmpdir
+      if File.directory? @tmpdir
+        FileUtils.remove_entry @tmpdir
+      end
     end
 
     def set_threads_count

test/test_02_video2ascii.rb

@@ -20,4 +20,13 @@ def test_generate_params
     test_width = 200
     assert_equal test_width , @generator.generate(width: test_width).width
   end
+
+  def test_generate_params
+    test_width = 200
+    assert_equal test_width , @generator.generate(width: test_width).width
+  end
+
+  def teardown
+    @generator.after_clean
+  end
 end

test/test_03_video2ascii_play.rb

@@ -12,4 +12,8 @@ def test_video_play
     @generator.generate
     assert_equal true , @generator.play
   end
+
+  def teardown
+    @generator.after_clean
+  end
 end