Skip to main content
Code Review

Return to Answer

replaced http://stackoverflow.com/ with https://stackoverflow.com/
Source Link
Community Bot
Community Bot
  • 1

Other reviewers have already covered the CSS well.

As for this HTML:

<h3>Color Reference</h3>
    <code class="pln ">Plain text</code><br /> 
    <code class="str">"String content"</code><br />
    <code class="kwd">Keyword</code><br />

I think <br/> is not a good practicenot a good practice in general. I recommend to get rid of those, and do something like this instead:

<h3>Color Reference</h3>
<ul class="examples">
    <li><code class="pln ">Plain text</code></li>
    <li><code class="str">"String content"</code></li>
    <li><code class="kwd">Keyword</code></li>
</ul>

In the <head> of your tester page (decidedly not in the prettify CSS file), add custom <style> to format examples.p appropriately.

Other reviewers have already covered the CSS well.

As for this HTML:

<h3>Color Reference</h3>
    <code class="pln ">Plain text</code><br /> 
    <code class="str">"String content"</code><br />
    <code class="kwd">Keyword</code><br />

I think <br/> is not a good practice in general. I recommend to get rid of those, and do something like this instead:

<h3>Color Reference</h3>
<ul class="examples">
    <li><code class="pln ">Plain text</code></li>
    <li><code class="str">"String content"</code></li>
    <li><code class="kwd">Keyword</code></li>
</ul>

In the <head> of your tester page (decidedly not in the prettify CSS file), add custom <style> to format examples.p appropriately.

Other reviewers have already covered the CSS well.

As for this HTML:

<h3>Color Reference</h3>
    <code class="pln ">Plain text</code><br /> 
    <code class="str">"String content"</code><br />
    <code class="kwd">Keyword</code><br />

I think <br/> is not a good practice in general. I recommend to get rid of those, and do something like this instead:

<h3>Color Reference</h3>
<ul class="examples">
    <li><code class="pln ">Plain text</code></li>
    <li><code class="str">"String content"</code></li>
    <li><code class="kwd">Keyword</code></li>
</ul>

In the <head> of your tester page (decidedly not in the prettify CSS file), add custom <style> to format examples.p appropriately.

added 4 characters in body
Source Link
janos
janos
  • 113.1k
  • 15
  • 154
  • 396

Other reviewers have already covered the CSS well.

As for this HTML:

<h3>Color Reference</h3>
    <code class="pln ">Plain text</code><br /> 
    <code class="str">"String content"</code><br />
    <code class="kwd">Keyword</code><br />

I think <br/> is not a good practice in general. I recommend to get rid of those, and do something like this instead:

<h3>Color Reference</h3>
<div<ul class="examples">
    <p><code<li><code class="pln ">Plain text</code></p>li>
    <p><code<li><code class="str">"String content"</code></p>li>
    <p><code<li><code class="kwd">Keyword</code></p>li>
</div>ul>

In the <head> of your tester page (decidedly not in the prettify CSS file), add custom <style> to format examples.p appropriately.

Other reviewers have already covered the CSS well.

As for this HTML:

<h3>Color Reference</h3>
    <code class="pln ">Plain text</code><br /> 
    <code class="str">"String content"</code><br />
    <code class="kwd">Keyword</code><br />

I think <br/> is not a good practice in general. I recommend to get rid of those, and do something like this instead:

<h3>Color Reference</h3>
<div class="examples">
    <p><code class="pln ">Plain text</code></p>
    <p><code class="str">"String content"</code></p>
    <p><code class="kwd">Keyword</code></p>
</div>

In the <head> of your tester page (decidedly not in the prettify CSS file), add custom <style> to format examples.p appropriately.

Other reviewers have already covered the CSS well.

As for this HTML:

<h3>Color Reference</h3>
    <code class="pln ">Plain text</code><br /> 
    <code class="str">"String content"</code><br />
    <code class="kwd">Keyword</code><br />

I think <br/> is not a good practice in general. I recommend to get rid of those, and do something like this instead:

<h3>Color Reference</h3>
<ul class="examples">
    <li><code class="pln ">Plain text</code></li>
    <li><code class="str">"String content"</code></li>
    <li><code class="kwd">Keyword</code></li>
</ul>

In the <head> of your tester page (decidedly not in the prettify CSS file), add custom <style> to format examples.p appropriately.

Source Link
janos
janos
  • 113.1k
  • 15
  • 154
  • 396

Other reviewers have already covered the CSS well.

As for this HTML:

<h3>Color Reference</h3>
    <code class="pln ">Plain text</code><br /> 
    <code class="str">"String content"</code><br />
    <code class="kwd">Keyword</code><br />

I think <br/> is not a good practice in general. I recommend to get rid of those, and do something like this instead:

<h3>Color Reference</h3>
<div class="examples">
    <p><code class="pln ">Plain text</code></p>
    <p><code class="str">"String content"</code></p>
    <p><code class="kwd">Keyword</code></p>
</div>

In the <head> of your tester page (decidedly not in the prettify CSS file), add custom <style> to format examples.p appropriately.