Skip to main content
Code Review

Return to Question

fixed tags and title
Link
Malachi
Malachi
  • 29.1k
  • 11
  • 87
  • 188

Calling stored procedure with a sql commandsqlCommand

fixed tags and title
Source Link
edit approved Jun 4, 2015 at 14:50
Quill
edit approved Jun 4, 2015 at 14:50
Quill
  • 12.1k
  • 5
  • 41
  • 94

Calling stored procedure with `sqlCommand`a sql command

I have the following code as part of an sqlcommandsqlCommand which is calling a stored procedure:

Dim groupObj

If groupId = 0 Then
    groupObj = DBNull.Value
Else
    groupObj = groupId
End If

Dim siteObj

If siteId = 0 Then
    siteObj = DBNull.Value
Else
    siteObj = siteId
End If

sqlCommand.Parameters.Add(New SqlClient.SqlParameter("GroupID", SqlDbType.Decimal)).Value = groupObj
sqlCommand.Parameters.Add(New SqlClient.SqlParameter("SiteID", SqlDbType.Decimal)).Value = siteObj

I basically want to check for a condition and (if true) send a DBNull instead. This code looks awful however - is there a way to succinct this up?

Calling stored procedure with `sqlCommand`

I have the following code as part of an sqlcommand which is calling a stored procedure:

Dim groupObj

If groupId = 0 Then
    groupObj = DBNull.Value
Else
    groupObj = groupId
End If

Dim siteObj

If siteId = 0 Then
    siteObj = DBNull.Value
Else
    siteObj = siteId
End If

sqlCommand.Parameters.Add(New SqlClient.SqlParameter("GroupID", SqlDbType.Decimal)).Value = groupObj
sqlCommand.Parameters.Add(New SqlClient.SqlParameter("SiteID", SqlDbType.Decimal)).Value = siteObj

I basically want to check for a condition and (if true) send a DBNull instead. This code looks awful however - is there a way to succinct this up?

Calling stored procedure with a sql command

I have the following code as part of an sqlCommand which is calling a stored procedure:

Dim groupObj

If groupId = 0 Then
    groupObj = DBNull.Value
Else
    groupObj = groupId
End If

Dim siteObj

If siteId = 0 Then
    siteObj = DBNull.Value
Else
    siteObj = siteId
End If

sqlCommand.Parameters.Add(New SqlClient.SqlParameter("GroupID", SqlDbType.Decimal)).Value = groupObj
sqlCommand.Parameters.Add(New SqlClient.SqlParameter("SiteID", SqlDbType.Decimal)).Value = siteObj

I basically want to check for a condition and (if true) send a DBNull instead. This code looks awful however - is there a way to succinct this up?

Tweeted twitter.com/#!/StackCodeReview/status/134953767954153472
formatting change
Source Link
edit approved Nov 10, 2011 at 17:55
Damith
edit approved Nov 10, 2011 at 17:55
Damith
  • 195
  • 5

I have the following code as part of an sqlcommandsqlcommand which is calling a stored procedure:

            Dim groupObj

            If groupId = 0 Then
                groupObj = DBNull.Value
            Else
                groupObj = groupId
            End If

            Dim siteObj

            If siteId = 0 Then
                siteObj = DBNull.Value
            Else
                siteObj = siteId
            End If

            sqlCommand.Parameters.Add(New SqlClient.SqlParameter("GroupID", SqlDbType.Decimal)).Value = groupObj
            sqlCommand.Parameters.Add(New SqlClient.SqlParameter("SiteID", SqlDbType.Decimal)).Value = siteObj

I basically want to check for a condition and (if truetrue) send a DBNullDBNull instead. This code looks awful however - is there a way to succinct this up?

I have the following code as part of an sqlcommand which is calling a stored procedure:

            Dim groupObj

            If groupId = 0 Then
                groupObj = DBNull.Value
            Else
                groupObj = groupId
            End If

            Dim siteObj

            If siteId = 0 Then
                siteObj = DBNull.Value
            Else
                siteObj = siteId
            End If

            sqlCommand.Parameters.Add(New SqlClient.SqlParameter("GroupID", SqlDbType.Decimal)).Value = groupObj
            sqlCommand.Parameters.Add(New SqlClient.SqlParameter("SiteID", SqlDbType.Decimal)).Value = siteObj

I basically want to check for a condition and (if true) send a DBNull instead. This code looks awful however - is there a way to succinct this up?

I have the following code as part of an sqlcommand which is calling a stored procedure:

Dim groupObj

If groupId = 0 Then
    groupObj = DBNull.Value
Else
    groupObj = groupId
End If

Dim siteObj

If siteId = 0 Then
    siteObj = DBNull.Value
Else
    siteObj = siteId
End If

sqlCommand.Parameters.Add(New SqlClient.SqlParameter("GroupID", SqlDbType.Decimal)).Value = groupObj
sqlCommand.Parameters.Add(New SqlClient.SqlParameter("SiteID", SqlDbType.Decimal)).Value = siteObj

I basically want to check for a condition and (if true) send a DBNull instead. This code looks awful however - is there a way to succinct this up?

Source Link
m.edmondson
m.edmondson
  • 327
  • 1
  • 2
  • 9