Revisions to Password storage with gatherer plugin in Python

added 5 characters in body

Source Link

edited Sep 5 at 14:50

A few suggestions:

    def __iter__(self):
        for title, passwords in self._store.items():
            yield title, passwords

This can be simplified to:

    def __iter__(self):
        yield from self._store.items()

Also here:

        max_title_length = min(
            MAX_COL_WIDTH, max(len(title) for title in self._store.keys())
        )

Can be shortened by using the key argument to len:

        max_title_length = min(
            MAX_COL_WIDTH, len(max(self._store.keys(), key=len))
        )

A few suggestions:

    def __iter__(self):
        for title, passwords in self._store.items():
            yield title, passwords

This can be simplified to:

    def __iter__(self):
        yield from self._store.items()

Also here:

        max_title_length = min(
            MAX_COL_WIDTH, max(len(title) for title in self._store.keys())
        )

Can be shortened by using the key argument to len:

        max_title_length = min(
            MAX_COL_WIDTH, max(self._store.keys(), key=len)
        )

A few suggestions:

    def __iter__(self):
        for title, passwords in self._store.items():
            yield title, passwords

This can be simplified to:

    def __iter__(self):
        yield from self._store.items()

Also here:

        max_title_length = min(
            MAX_COL_WIDTH, max(len(title) for title in self._store.keys())
        )

Can be shortened by using the key argument to len:

        max_title_length = min(
            MAX_COL_WIDTH, len(max(self._store.keys(), key=len))
        )

I think `len` is meant here for the `key` argument

Source Link

A few suggestions:

    def __iter__(self):
        for title, passwords in self._store.items():
            yield title, passwords

This can be simplified to:

    def __iter__(self):
        yield from self._store.items()

Also here:

        max_title_length = min(
            MAX_COL_WIDTH, max(len(title) for title in self._store.keys())
        )

Can be shortened by using the key argument to maxlen:

        max_title_length = min(
            MAX_COL_WIDTH, max(self._store.keys(), key=len)
        )

A few suggestions:

    def __iter__(self):
        for title, passwords in self._store.items():
            yield title, passwords

This can be simplified to:

    def __iter__(self):
        yield from self._store.items()

Also here:

        max_title_length = min(
            MAX_COL_WIDTH, max(len(title) for title in self._store.keys())
        )

Can be shortened by using the key argument to max:

        max_title_length = min(
            MAX_COL_WIDTH, max(self._store.keys(), key=len)
        )

A few suggestions:

    def __iter__(self):
        for title, passwords in self._store.items():
            yield title, passwords

This can be simplified to:

    def __iter__(self):
        yield from self._store.items()

Also here:

        max_title_length = min(
            MAX_COL_WIDTH, max(len(title) for title in self._store.keys())
        )

Can be shortened by using the key argument to len:

        max_title_length = min(
            MAX_COL_WIDTH, max(self._store.keys(), key=len)
        )

Source Link

answered Jul 31 at 23:14

A few suggestions:

    def __iter__(self):
        for title, passwords in self._store.items():
            yield title, passwords

This can be simplified to:

    def __iter__(self):
        yield from self._store.items()

Also here:

        max_title_length = min(
            MAX_COL_WIDTH, max(len(title) for title in self._store.keys())
        )

Can be shortened by using the key argument to max:

        max_title_length = min(
            MAX_COL_WIDTH, max(self._store.keys(), key=len)
        )

Return to Answer