Skip to main content
Code Review

Return to Answer

added 58 characters in body; added 12 characters in body
Source Link
wilhelmtell
wilhelmtell
  • 151
  • 4

I'd use a std::ostringstream because you don't use (seem to need) the formatting capabilities of std::istringstream.

  • I'd use a std::ostringstream because you don't use (seem to need) the formatting capabilities of std::istringstream.
  • What happens when formatting fails? Can you check for failure?

I'd use a std::ostringstream because you don't use (seem to need) the formatting capabilities of std::istringstream.

  • I'd use a std::ostringstream because you don't use (seem to need) the formatting capabilities of std::istringstream.
  • What happens when formatting fails? Can you check for failure?
Source Link
wilhelmtell
wilhelmtell
  • 151
  • 4

I'd use a std::ostringstream because you don't use (seem to need) the formatting capabilities of std::istringstream.