Timeline for Spring boot loadbyusername
Current License: CC BY-SA 4.0
11 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Mar 19, 2020 at 11:57 | comment | added | lukascode | Yes, you should have some impl of UserDetails either so AccountDetails is ok. | |
| Mar 19, 2020 at 11:51 | comment | added | John Spring | I mean accountdetails model | |
| Mar 19, 2020 at 11:38 | comment | added | lukascode | No, that merged class can implement the UserDetailsService. | |
| Mar 19, 2020 at 11:33 | comment | added | John Spring | also do I still need accountdetails class after I merged accountservice and accountdetailsservice | |
| Mar 19, 2020 at 11:29 | comment | added | lukascode |
I think it depends on the business case but In general it is not a problem. Notice that we expect that after this remove method ends we should not see particular user account on the database and that is true, if account exists it would be deleted if not nothing happens and thats ok because that is expected behaviour (particular user account should not exists on db).
|
|
| Mar 19, 2020 at 11:15 | vote | accept | John Spring | ||
| Mar 19, 2020 at 11:06 | comment | added | John Spring | is it problematic if we dont check if the username is in db or not before deleting? | |
| Mar 19, 2020 at 8:57 | comment | added | lukascode | @JohnSpring I updated Tip 5. | |
| Mar 19, 2020 at 8:55 | history | edited | lukascode | CC BY-SA 4.0 |
added 225 characters in body
|
| Mar 19, 2020 at 8:34 | comment | added | John Spring | Thanks for great tips. How can I reduce complexity of remove method in service? | |
| Mar 18, 2020 at 21:43 | history | answered | lukascode | CC BY-SA 4.0 |