Timeline for Simple MVP Name-Finder
Current License: CC BY-SA 4.0
14 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Oct 16, 2018 at 21:10 | review | First posts | |||
| Oct 16, 2018 at 22:03 | |||||
| Oct 11, 2018 at 14:40 | review | Low quality posts | |||
| Oct 11, 2018 at 14:45 | |||||
| Oct 11, 2018 at 14:37 | history | edited | Mathieu Guindon | CC BY-SA 4.0 |
edited comment into an actual Code Review answer
|
| Oct 11, 2018 at 13:13 | comment | added | Piotr Polit |
You are absolutely right Mathieu, indeed I had a function calling frmView.Show. I have started my app about 3 years ago and now, when it is quite large it deserves a nice GUI. I played with SmartUI a bit and got quite tired of even thinking about applying this approach, so decided to do it right first time when I read about MVP. During my research I have seen your articles and read about the RubberDuck project, but I did not even dare to invoke your name. Many thanks for your help. Just said to my colleague the MVP God replied to me. That felt slightly worrisome. =)
|
|
| Oct 11, 2018 at 12:47 | history | edited | Simon Forsberg | CC BY-SA 4.0 |
Answers are not for help with troubleshooting
|
| Oct 11, 2018 at 12:09 | comment | added | Mathieu Guindon | As I said above, you need to use the presenter, not the form's default instance (which I'm assuming is what you're doing, since you're not showing how the form is being created). This article, and this article, should help understand what's going on and why. | |
| Oct 11, 2018 at 12:04 | comment | added | Mathieu Guindon |
You're probably having the form running the show (e.g. UserForm1.Show), which is exactly what model-view-presenter is preventing. The presenter is responsible for showing the form, and setting the model reference (this.Data being Nothing is why you're getting error 91). That said this isn't a troubleshooting site, answers are supposed to be reviewing the OP's code, not asking to clarify how it works.
|
|
| Oct 11, 2018 at 12:01 | history | edited | Piotr Polit | CC BY-SA 4.0 |
added 89 characters in body
|
| Oct 11, 2018 at 12:00 | review | Low quality posts | |||
| Oct 11, 2018 at 13:10 | |||||
| Oct 11, 2018 at 11:57 | comment | added | Piotr Polit | Yeah, I named the ComboBox the same: | |
| Oct 11, 2018 at 11:36 | comment | added | CallumDA | TeamSelect is the name of the team drop down box. I provided a list of these names in the original question :) | |
| Oct 11, 2018 at 11:35 | review | Late answers | |||
| Oct 11, 2018 at 11:55 | |||||
| Oct 11, 2018 at 11:22 | comment | added | CallumDA | Hi Piotr, the code should work as it is otherwise it shouldn’t be on Code Review. Thanks for taking a look - I’ll check the code again myself when I get a chance and if it actually doesn’t work I’ll remove the question | |
| Oct 11, 2018 at 11:17 | history | answered | Piotr Polit | CC BY-SA 4.0 |