Return to Answer

added 2 characters in body

Source Link

edited Jan 21, 2018 at 18:40

The code for apple and linux cases is identical (except one case). Consider
```
  #if defined(__APPLE__) || defined(__linux__)
  #define POSIX
  #endif
```
and consolidate the identical blocks under #ifdef POSIX. Or consistently do
```
  #ifdef __WIN32__
  ....
  #else
  ....
  #endif
```
as you did near the end of forp.
Determining a number of processors by parsing an output of an external command doesn't look right. See this answer for details.
All functions except forp shall be static. Especially concurrent_queue_t_enqueue, which is surely not designed for a public access.
I don't see why concurrent_queue_t is implemented as a linked list. An array of task_desc with a mutex-protected cursor seems enough. It is much easier on memory.
It is advisable (though not mandatory) to avoid _t type names. See B.2.12 Data TypesB.2.12 Data Types section of the Posix standard (1003.1, Rationale (Informative)).

The code for apple and linux cases is identical (except one case). Consider
```
  #if defined(__APPLE__) || defined(__linux__)
  #define POSIX
  #endif
```
and consolidate the identical blocks under #ifdef POSIX. Or consistently do
```
  #ifdef __WIN32__
  ....
  #else
  ....
  #endif
```
as you did near the end of forp.
Determining a number of processors by parsing an output of an external command doesn't look right. See this answer for details.
All functions except forp shall be static. Especially concurrent_queue_t_enqueue, which is surely not designed for a public access.
I don't see why concurrent_queue_t is implemented as a linked list. An array of task_desc with a mutex-protected cursor seems enough. It is much easier on memory.
It is advisable (though not mandatory) to avoid _t type names. See B.2.12 Data Types section of the Posix standard (1003.1, Rationale (Informative)).

The code for apple and linux cases is identical (except one case). Consider
```
  #if defined(__APPLE__) || defined(__linux__)
  #define POSIX
  #endif
```
and consolidate the identical blocks under #ifdef POSIX. Or consistently do
```
  #ifdef __WIN32__
  ....
  #else
  ....
  #endif
```
as you did near the end of forp.
Determining a number of processors by parsing an output of an external command doesn't look right. See this answer for details.
All functions except forp shall be static. Especially concurrent_queue_t_enqueue, which is surely not designed for a public access.
I don't see why concurrent_queue_t is implemented as a linked list. An array of task_desc with a mutex-protected cursor seems enough. It is much easier on memory.
It is advisable (though not mandatory) to avoid _t type names. See B.2.12 Data Types section of the Posix standard (1003.1, Rationale (Informative)).

Source Link

answered Jan 21, 2018 at 18:35

The code for apple and linux cases is identical (except one case). Consider
```
  #if defined(__APPLE__) || defined(__linux__)
  #define POSIX
  #endif
```
and consolidate the identical blocks under #ifdef POSIX. Or consistently do
```
  #ifdef __WIN32__
  ....
  #else
  ....
  #endif
```
as you did near the end of forp.
Determining a number of processors by parsing an output of an external command doesn't look right. See this answer for details.
All functions except forp shall be static. Especially concurrent_queue_t_enqueue, which is surely not designed for a public access.
I don't see why concurrent_queue_t is implemented as a linked list. An array of task_desc with a mutex-protected cursor seems enough. It is much easier on memory.
It is advisable (though not mandatory) to avoid _t type names. See B.2.12 Data Types section of the Posix standard (1003.1, Rationale (Informative)).