Skip to main content
Code Review

Return to Question

fixed the misleading indentation using Chrome's {} button
Source Link
edit approved Oct 20, 2016 at 19:29
woxxom
edit approved Oct 20, 2016 at 19:29
woxxom
  • 2k
  • 1
  • 10
  • 12

Can someone review my code? I am trying to implement radix sort in JavaScript.

var numbers=[90numbers = [90, 46, 7, 12, 100, 68];
var length=numberslength = numbers.length;
var buckets=newbuckets = new Array(10); 

Clear();
function Clear() {
    for (var i=0;i<10;i++i = 0; i < 10; i++)
  buckets[i]=[];      buckets[i] = [];
}
 

RadixSort();
function RadixSort() {
    var maxElement=MathmaxElement = Math.max.apply(null , numbers);
    var maxDigits=GetDigitsCountmaxDigits = GetDigitsCount(maxElement);
    var count=0;count = 0;
    while (count<maxDigitscount < maxDigits) {
        CopyToArray();
        for (var index=0;index<length;index++index = 0; index < length; index++) {
            var tenIndex=MathtenIndex = Math.pow(10, count);
            var remNumber=parseIntremNumber = parseInt(numbers[index] / tenIndex, 10);
            var bucketIndex=remNumber%10;
bucketIndex = remNumber % 10;
            buckets[bucketIndex].push(numbers[index]);
        }
  
       count++;
    }
  
   for (var i=0;i<9;i++i = 0; i < 9; i++) {
        var arr=buckets[i];arr = buckets[i];
        var arrLength=arrarrLength = arr.length;
        for (var j=0;j<arrLength;j++j = 0; j < arrLength; j++)
            console.log(arr[j]);
    }
}
   
function GetDigitsCount(number)
  {
    var count=0;count = 0;
    while (number>0number > 0) {
     number=parseInt   number = parseInt(number / 10); 
        count++;
    }
    return count;
  }

  function CopyToArray() {
    var k=0;k = 0;
    for (var i=0;i<10;i++i = 0; i < 10; i++) {
        var arr=buckets[i];arr = buckets[i];
        var arrLength=arrarrLength = arr.length;
        for (var j=0;j<arrLength;j++j = 0; j < arrLength; j++) {
      numbers[k++]=arr[j];
    }
  numbers[k++] = buckets[i]=[];arr[j];
        }
        buckets[i] = [];
    }
}

Can someone review my code? I am trying to implement radix sort in JavaScript.

var numbers=[90,46,7,12,100,68];
var length=numbers.length;
var buckets=new Array(10);
Clear();
function Clear(){
for(var i=0;i<10;i++)
  buckets[i]=[];
}
 

RadixSort();
function RadixSort(){
  var maxElement=Math.max.apply(null,numbers);
  var maxDigits=GetDigitsCount(maxElement);
  var count=0;
  while(count<maxDigits){
    CopyToArray();
  for(var index=0;index<length;index++){
    var tenIndex=Math.pow(10,count);
    var remNumber=parseInt(numbers[index]/tenIndex,10);
    var bucketIndex=remNumber%10;
    
    buckets[bucketIndex].push(numbers[index]);
  }
  
     count++;
  }
  
   for(var i=0;i<9;i++){
    var arr=buckets[i];
    var arrLength=arr.length;
    for(var j=0;j<arrLength;j++)
      console.log(arr[j]);
  }
}
  function GetDigitsCount(number)
  {
    var count=0;
    while(number>0){
     number=parseInt(number/10); 
      count++;
    }
    return count;
  }

  function CopyToArray(){
    var k=0;
  for(var i=0;i<10;i++){
    var arr=buckets[i];
    var arrLength=arr.length;
    for(var j=0;j<arrLength;j++){
      numbers[k++]=arr[j];
    }
    buckets[i]=[];
  }

  }

Can someone review my code? I am trying to implement radix sort in JavaScript.

var numbers = [90, 46, 7, 12, 100, 68];
var length = numbers.length;
var buckets = new Array(10); 

Clear();
function Clear() {
    for (var i = 0; i < 10; i++)
        buckets[i] = [];
}

RadixSort();
function RadixSort() {
    var maxElement = Math.max.apply(null , numbers);
    var maxDigits = GetDigitsCount(maxElement);
    var count = 0;
    while (count < maxDigits) {
        CopyToArray();
        for (var index = 0; index < length; index++) {
            var tenIndex = Math.pow(10, count);
            var remNumber = parseInt(numbers[index] / tenIndex, 10);
            var bucketIndex = remNumber % 10;
            buckets[bucketIndex].push(numbers[index]);
        }
        count++;
    }
    for (var i = 0; i < 9; i++) {
        var arr = buckets[i];
        var arrLength = arr.length;
        for (var j = 0; j < arrLength; j++)
            console.log(arr[j]);
    }
}
 
function GetDigitsCount(number) {
    var count = 0;
    while (number > 0) {
        number = parseInt(number / 10);
        count++;
    }
    return count;
}

function CopyToArray() {
    var k = 0;
    for (var i = 0; i < 10; i++) {
        var arr = buckets[i];
        var arrLength = arr.length;
        for (var j = 0; j < arrLength; j++) {
            numbers[k++] = arr[j];
        }
        buckets[i] = [];
    }
}

deleted 36 characters in body; edited title
Source Link
Jamal
Jamal
  • 35.2k
  • 13
  • 134
  • 238

Implementing RadixSort using javascriptJavaScript

Can some onesomeone review my code.

? I am trying to implement radix sort in javascript

Here is my following codeJavaScript.

var numbers=[90,46,7,12,100,68];
var length=numbers.length;
var buckets=new Array(10);
Clear();
function Clear(){
for(var i=0;i<10;i++)
  buckets[i]=[];
}


RadixSort();
function RadixSort(){
  var maxElement=Math.max.apply(null,numbers);
  var maxDigits=GetDigitsCount(maxElement);
  var count=0;
  while(count<maxDigits){
    CopyToArray();
  for(var index=0;index<length;index++){
    var tenIndex=Math.pow(10,count);
    var remNumber=parseInt(numbers[index]/tenIndex,10);
    var bucketIndex=remNumber%10;
    
    buckets[bucketIndex].push(numbers[index]);
  }
  
    count++;
  }
  
  for(var i=0;i<9;i++){
    var arr=buckets[i];
    var arrLength=arr.length;
    for(var j=0;j<arrLength;j++)
      console.log(arr[j]);
  }
}
  function GetDigitsCount(number)
  {
    var count=0;
    while(number>0){
     number=parseInt(number/10); 
      count++;
    }
    return count;
  }

  function CopyToArray(){
    var k=0;
  for(var i=0;i<10;i++){
    var arr=buckets[i];
    var arrLength=arr.length;
    for(var j=0;j<arrLength;j++){
      numbers[k++]=arr[j];
    }
    buckets[i]=[];
  }

  }

Implementing RadixSort using javascript

Can some one review my code.

I am trying to implement radix sort in javascript

Here is my following code

var numbers=[90,46,7,12,100,68];
var length=numbers.length;
var buckets=new Array(10);
Clear();
function Clear(){
for(var i=0;i<10;i++)
  buckets[i]=[];
}


RadixSort();
function RadixSort(){
  var maxElement=Math.max.apply(null,numbers);
  var maxDigits=GetDigitsCount(maxElement);
  var count=0;
  while(count<maxDigits){
    CopyToArray();
  for(var index=0;index<length;index++){
    var tenIndex=Math.pow(10,count);
    var remNumber=parseInt(numbers[index]/tenIndex,10);
    var bucketIndex=remNumber%10;
    
    buckets[bucketIndex].push(numbers[index]);
  }
  
    count++;
  }
  
  for(var i=0;i<9;i++){
    var arr=buckets[i];
    var arrLength=arr.length;
    for(var j=0;j<arrLength;j++)
      console.log(arr[j]);
  }
}
  function GetDigitsCount(number)
  {
    var count=0;
    while(number>0){
     number=parseInt(number/10); 
      count++;
    }
    return count;
  }

  function CopyToArray(){
    var k=0;
  for(var i=0;i<10;i++){
    var arr=buckets[i];
    var arrLength=arr.length;
    for(var j=0;j<arrLength;j++){
      numbers[k++]=arr[j];
    }
    buckets[i]=[];
  }

  }

Implementing RadixSort using JavaScript

Can someone review my code? I am trying to implement radix sort in JavaScript.

var numbers=[90,46,7,12,100,68];
var length=numbers.length;
var buckets=new Array(10);
Clear();
function Clear(){
for(var i=0;i<10;i++)
  buckets[i]=[];
}


RadixSort();
function RadixSort(){
  var maxElement=Math.max.apply(null,numbers);
  var maxDigits=GetDigitsCount(maxElement);
  var count=0;
  while(count<maxDigits){
    CopyToArray();
  for(var index=0;index<length;index++){
    var tenIndex=Math.pow(10,count);
    var remNumber=parseInt(numbers[index]/tenIndex,10);
    var bucketIndex=remNumber%10;
    
    buckets[bucketIndex].push(numbers[index]);
  }
  
    count++;
  }
  
  for(var i=0;i<9;i++){
    var arr=buckets[i];
    var arrLength=arr.length;
    for(var j=0;j<arrLength;j++)
      console.log(arr[j]);
  }
}
  function GetDigitsCount(number)
  {
    var count=0;
    while(number>0){
     number=parseInt(number/10); 
      count++;
    }
    return count;
  }

  function CopyToArray(){
    var k=0;
  for(var i=0;i<10;i++){
    var arr=buckets[i];
    var arrLength=arr.length;
    for(var j=0;j<arrLength;j++){
      numbers[k++]=arr[j];
    }
    buckets[i]=[];
  }

  }

Source Link
Geeky
Geeky
  • 145
  • 9

Implementing RadixSort using javascript

Can some one review my code.

I am trying to implement radix sort in javascript

Here is my following code

var numbers=[90,46,7,12,100,68];
var length=numbers.length;
var buckets=new Array(10);
Clear();
function Clear(){
for(var i=0;i<10;i++)
  buckets[i]=[];
}


RadixSort();
function RadixSort(){
  var maxElement=Math.max.apply(null,numbers);
  var maxDigits=GetDigitsCount(maxElement);
  var count=0;
  while(count<maxDigits){
    CopyToArray();
  for(var index=0;index<length;index++){
    var tenIndex=Math.pow(10,count);
    var remNumber=parseInt(numbers[index]/tenIndex,10);
    var bucketIndex=remNumber%10;
    
    buckets[bucketIndex].push(numbers[index]);
  }
  
    count++;
  }
  
  for(var i=0;i<9;i++){
    var arr=buckets[i];
    var arrLength=arr.length;
    for(var j=0;j<arrLength;j++)
      console.log(arr[j]);
  }
}
  function GetDigitsCount(number)
  {
    var count=0;
    while(number>0){
     number=parseInt(number/10); 
      count++;
    }
    return count;
  }

  function CopyToArray(){
    var k=0;
  for(var i=0;i<10;i++){
    var arr=buckets[i];
    var arrLength=arr.length;
    for(var j=0;j<arrLength;j++){
      numbers[k++]=arr[j];
    }
    buckets[i]=[];
  }

  }