aboutsummaryrefslogtreecommitdiff
diff options
authorWarner Losh <[email protected]>2025-12-04 04:05:06 +0000
committerWarner Losh <[email protected]>2025-12-04 06:04:34 +0000
commita8b0208e7e989c0876f73e1953f66542678b9004 (patch)
treeb71110d671c7e0b0cdfafa5943c66dc6fee07845
parent9ec8196f68bac015965164f7f1a65c619bab4e85 (diff)
nvme: Fix devd logging of SMART_ERRORHEADmain
Remove extra arg so that we have type=SMART_ERROR rather than an invalid message. Also log all aens. Sponsored by: Netflix
-rw-r--r--sys/dev/nvme/nvme_ctrlr.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/sys/dev/nvme/nvme_ctrlr.c b/sys/dev/nvme/nvme_ctrlr.c
index 1ad4735cbef8..55b6d6b745cf 100644
--- a/sys/dev/nvme/nvme_ctrlr.c
+++ b/sys/dev/nvme/nvme_ctrlr.c
@@ -677,7 +677,7 @@ nvme_ctrlr_log_critical_warnings(struct nvme_controller *ctrlr,
nvme_printf(ctrlr, "SMART WARNING: unknown critical warning(s): state = 0x%02x\n",
state & NVME_CRIT_WARN_ST_RESERVED_MASK);
- nvme_ctrlr_devctl(ctrlr, "critical", "SMART_ERROR", "state=0x%02x", state);
+ nvme_ctrlr_devctl(ctrlr, "SMART_ERROR", "state=0x%02x", state);
}
static void
@@ -1143,6 +1143,10 @@ nvme_ctrlr_aer_task(void *arg, int pending)
goto out;
}
+ nvme_ctrlr_devctl(ctrlr, "aen", "type=0x%x info=0x%x page=0x%x",
+ NVMEV(NVME_ASYNC_EVENT_TYPE, aer->cpl.cdw0),
+ NVMEV(NVME_ASYNC_EVENT_INFO, aer->cpl.cdw0), aer->log_page_id);
+
aer->log_page_size = 0;
len = nvme_ctrlr_get_log_page_size(aer->ctrlr, aer->log_page_id);
nvme_ctrlr_cmd_get_log_page(aer->ctrlr, aer->log_page_id,