We currently make two calls to nextItem.focus() in the navigate method of SelectControlBaseElement. The second call is redundant, and should be removed.

Hello, I'm a new contributor and I'm going to jump on this bug.

Hey Hanna Jones, I believe I implemented the necessary changes. Are there any tests I should be running? Also Phabricator Revision ID D271112 was a mistake as I committed to main instead of committing to a new branch.

Hi Dominique, thanks for helping with this! You can run toolkit/content/tests/widgets/test_moz_radio_group.html and toolkit/content/tests/widgets/test_moz_visual_picker.html locally since both of those elements use lit-select-control under the hood. As far as the accidental revision goes, feel free to just abandon that patch.

I ran the tests and it looks good to me!

Mochitest results for toolkit/content/tests/widgets/test_moz_radio_group.html

Overall Summary
===============

mochitest-chrome
~~~~~~~~~~~~~~~~
Ran 182 checks (181 subtests, 1 tests)
Expected results: 182
Unexpected results: 0
OK

Mochitest results for toolkit/content/tests/widgets/test_moz_visual_picker.html

Overall Summary
===============

mochitest-chrome
~~~~~~~~~~~~~~~~
Ran 324 checks (323 subtests, 1 tests)
Expected results: 324
Unexpected results: 0
OK

As a new contributor, do you have any recommendations on a next bug I can work on? Appreciate it!

https://hg.mozilla.org/mozilla-central/rev/efedfb2c567b

Comment on attachment 9524228 [details]
WIP: Bug 1995325 - Remove duplicate nextItem.focus() call from lit-select-control.mjs

D271112 is a duplicate of D271455.

Comment on attachment 9524235 [details]
WIP: Bug 1995325 - Remove duplicate nextItem.focus() call from lit-select-control.mjs

D271115 is a duplicate of D271455.