(mozilla-central) for `./mach bootstrap` command, when system dependencies already satisfied, expect not to run `sudo` command
Categories
(Firefox Build System :: Bootstrap Configuration, enhancement, P5)
Tracking
(firefox124 fixed)
| Tracking | Status | |
|---|---|---|
| firefox124 | --- | fixed |
People
(Reporter: evan_greenup, Assigned: jnagele)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:120.0) Gecko/20100101 Firefox/120.0
Steps to reproduce:
When I clone mozilla-central and want to build it locally.
I run ./mach bootstrap command.
Actual results:
I use Arch Linux, and this command run sudo pacman -S <...>. Even though all of those system packages have already been installed by me.
And when I enter my password. It skip all packages.
Expected results:
It need to first check if the dependencies are satisfied, if so, do not waste user time to input password and install system packages.
Because I am Arch Linux user, it can simply be solved like this:
replace sudo pacman -S <...> with pacman -Qq <...> || sudo pacman -S <...>.
Because the system packages required by firefox is very common. And installed by most users especially the users who are going to build firefox from source.
Comment 1•2 years ago
|
||
The Bugbug bot thinks this bug should belong to the 'Firefox Build System::Bootstrap Configuration' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.
Comment 2•2 years ago
|
||
I think this is a good candidate for good-first-bug. If you're interested, here's a link to the firefox contributors quick reference. You'll only need to make changes in archlinux.py, basically just checking if the package is already installed, prior to running self.pacman_install() for both calls. You can set me as the reviewer, good luck!
| Assignee | ||
Comment 3•2 years ago
|
||
pacman_install() uses sudo pacman -S to install packages, which requires the user to enter their password for sudo even if there's nothing to do. Checking for installed packages using pacman -Q allows us to skip calling sudo when all packages are already installed.
Updated•2 years ago
|
Comment 5•2 years ago
|
||
| bugherder | ||
Description
•