Closed
Bug 1369281
Opened 9 years ago
Closed 9 years ago
Firefox UI display as zh-CN locale while android system locale is in zh-TW
Categories
(Firefox for Android Graveyard :: Locale switching and selection, defect, P1)
Tracking
(fennec+, firefox53 wontfix, firefox54+ verified, firefox55+ verified)
VERIFIED
FIXED
Firefox 55
People
(Reporter: maliu, Assigned: maliu)
Details
(Keywords: regression)
Attachments
(1 file)
|
Bug 1369281 - Simplify Locale setting string without variant/script which is from Locale.toString(),
59 bytes,
text/x-review-board-request
|
cnevinchen
:
review+
gchang
:
approval-mozilla-release+
|
Details |
STR:
* Set android system locale to zh-TW;
* Kill firefox process and launch;
* Observe UI locale in option menu and Settings
ER:
* UI display in zh-TW
AR:
* UI display in zh-CN
UI will be correct if user switched system locale, and it can be reproduced when process killed, cold start;
Comment 1•9 years ago
|
||
Peter, could you comment on what you saw on your phone? This is pretty severe and I think we should fix it sooner or later. Thanks!
Flags: needinfo?(petercpg)
Comment 2•9 years ago
|
||
From what I observe, Fennec displays in zh-CN when 繁體中文(台灣) has a higher order than 中文(台灣)in android locale preference. However if 中文(台灣) is more preferred, UI will display in zh-TW without problem.
Moreover, it seems that it's only possible to set 中文(台灣)in the first run UI, or being migrated from older android versions; if I remove that preference I'm unable to re-add it back, 繁體中文(台灣) still exists though.
I also noticed that when this bug happens, about: page in Fennec as well as some UI messages still displays in English, a normal zh-CN build should have these messages localized.
Other Information:
Device: Google Nexus 5X
Android Version: 7.1.2 (N2G47O)
Fennec Version: 53.0.2
Flags: needinfo?(petercpg)
Updated•9 years ago
|
status-firefox53:
--- → ?
status-firefox54:
--- → ?
status-firefox55:
--- → ?
Keywords: regression,
regressionwindow-wanted
Updated•9 years ago
|
Comment 3•9 years ago
|
||
Just fyr for in case someone reading this bug do not read localized locale names:
繁體中文(台灣) literally is Traditional Chinese (Taiwan), and 中文(台灣) is Chinese (Taiwan).
I suspect 繁體中文(台灣) is zh-Hant-TW, and 中文(台灣)should be zh-TW, but unfortunately I do not have android development environment in handy to confirm.
Comment 4•9 years ago
|
||
Too late to fix this in 53, but if 54 is affected, we might still be able to fix the issue for 54 in a dot release. We need to know if we still see the issue in 54 and 55.
Escalating to Joe and Tim since this may be a serious issue for Fennec, and if so, we should put resources into fixing it as soon as we can.
tracking-firefox54:
--- → +
tracking-firefox55:
--- → +
Flags: needinfo?(timdream)
Flags: needinfo?(jcheng)
Updated•9 years ago
|
tracking-fennec: --- → ?
Updated•9 years ago
|
tracking-fennec: ? → +
Priority: -- → P1
| Comment hidden (mozreview-request) |
Comment 6•9 years ago
|
||
| mozreview-review | ||
Comment on attachment 8875665 [details]
Bug 1369281 - Simplify Locale setting string without variant/script which is from Locale.toString(),
https://reviewboard.mozilla.org/r/147088/#review151250
LGTM
Attachment #8875665 -
Flags: review?(cnevinchen) → review+
| Comment hidden (mozreview-request) |
| Assignee | ||
Updated•9 years ago
|
Assignee: nobody → max
Pushed by max@mxli.us:
https://hg.mozilla.org/integration/autoland/rev/b977e23d261c
Simplify Locale setting string without variant/script which is from Locale.toString(), r=nechen
Comment 9•9 years ago
|
||
Talked to Max offline and he landed the patch. Thanks :)
Flags: needinfo?(timdream)
Comment 10•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
| Assignee | ||
Comment 12•9 years ago
|
||
Comment on attachment 8875665 [details]
Bug 1369281 - Simplify Locale setting string without variant/script which is from Locale.toString(),
Approval Request Comment
[Feature/Bug causing the regression]: RTL Locale Switcher.
[User impact if declined]: Cold launch will cause UI fallback to language default without country specific. zh_TW_#Hant -> zh(fallback zh_CN)
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]:
STR: Switch system locale to zh_TW and force stop fennec, launch fennec and check UI.
ER: UI display in zh_TW, not zh_CN
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: No
[Why is the change risky/not risky?]: Serialize locale to string manually with a simplified language_country format.
[String changes made/needed]: No
Flags: needinfo?(max)
Attachment #8875665 -
Flags: approval-mozilla-release?
Attachment #8875665 -
Flags: approval-mozilla-beta?
Updated•9 years ago
|
Comment 13•9 years ago
|
||
Comment on attachment 8875665 [details]
Bug 1369281 - Simplify Locale setting string without variant/script which is from Locale.toString(),
beta is going to be 55 later today. Updating the request.
Attachment #8875665 -
Flags: approval-mozilla-beta?
Comment 14•9 years ago
|
||
Looks like this missed landing for 54. If we do a dot release, we may want to take this patch.
Comment 15•9 years ago
|
||
Verified on Beta 55.0b1, that switching the Android system language to zh-TW 中文(台灣) displays the same language as installing the single locale build from archive http://archive.mozilla.org/pub/mobile/candidates/55.0b1-candidates/build2/android-api-15/zh-TW/. In previous Beta 54, the about:firefox and app settings were displayed in English as it was said in comment 2. This isn't reproducible anymore.
Verified as fixed.
Device:
-Motorola Nexus 6 (Android 7.0)
Status: RESOLVED → VERIFIED
Comment 16•9 years ago
|
||
Comment on attachment 8875665 [details]
Bug 1369281 - Simplify Locale setting string without variant/script which is from Locale.toString(),
Locale fix, we should definitely take this for beta 55.
Attachment #8875665 -
Flags: approval-mozilla-release? → approval-mozilla-release+
Comment 17•9 years ago
|
||
Comment on attachment 8875665 [details]
Bug 1369281 - Simplify Locale setting string without variant/script which is from Locale.toString(),
My mistake, I was reviewing beta uplift requests in another window, and somehow missed this was for release. Leaving this for gchang to review.
Attachment #8875665 -
Flags: approval-mozilla-release+ → approval-mozilla-release?
Comment 18•9 years ago
|
||
Comment on attachment 8875665 [details]
Bug 1369281 - Simplify Locale setting string without variant/script which is from Locale.toString(),
Locale fix. We're gonna take this one in 54.0.1.
Attachment #8875665 -
Flags: approval-mozilla-release? → approval-mozilla-release+
Comment 19•9 years ago
|
||
| bugherder uplift | ||
Comment 20•9 years ago
|
||
Devices:
- Nexus 5 (Android 6.0.1);
- LG G4 (Android 6.0);
-Asus ZenPad 8.0 Z380KL (Android 6.0.1);
Build:
- 54.0.1
Hello,
I've verified this using multiple devices and the issue was no longer reproducible. Marking as verified.
Updated•7 years ago
|
Flags: needinfo?(jcheng)
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
Comment 21•3 years ago
|
||
Removing regressionwindow-wanted keyword because this bug has been resolved.
Keywords: regressionwindow-wanted
Comment 22•3 years ago
|
||
Removing regressionwindow-wanted keyword because this bug has been resolved.
Comment 23•3 years ago
|
||
Removing regressionwindow-wanted keyword because this bug has been resolved.
You need to log in
before you can comment on or make changes to this bug.
Description
•