Try this way:
cpfromserver () {
files=''
for x in "$@"
do
files="$files /some/location/$x/$x.txt /some/location/$x/$x.pdf"
done
scp [email protected]:"$files" /somewhere/else/
}
Important caveat from comments: "It's worth noting for posterity that this solution definitely won't work for complicated filenames. If a filename contains a space, or a newline, or quotes, this approach will definitely fail."