Edit - Unix & Linux Stack Exchange

You are not logged in. Your edit will be placed in a queue until it is peer reviewed.

We welcome edits that make the post easier to understand and more valuable for readers. Because community members review edits, please try to make the post substantially better than how you found it, for example, by fixing grammar or adding additional resources and hyperlinks.

This would still execute echo $amount >>manual-entry no matter what the input is. That may not be what OP is looking for

jesse_b
– jesse_b

2019-05-02 18:20:36 +00:00
Commented May 2, 2019 at 18:20
indeed, I'd rewrite as if [[ "$amount" -gt 0 ]]; then echo "$amount" >> manual-entry; else echo "Echo a positive integer"; fi, or possibly use an until loop rather than a single if/then test.

DopeGhoti
– DopeGhoti

2019-05-02 18:33:35 +00:00
Commented May 2, 2019 at 18:33
@Jesse_b This can be fixed by adding && exit 0 after the echo

doneal24
– doneal24

2019-05-02 18:34:08 +00:00
Commented May 2, 2019 at 18:34
@DougO'Neal: In this case it's likely fine but it's generally bad practice to chain more than one && or || in a single list. I would recommend an if construct as DopeGhoti suggested.

jesse_b
– jesse_b

2019-05-02 18:36:01 +00:00
Commented May 2, 2019 at 18:36

Add a comment |

Correct minor typos or mistakes
Clarify meaning without changing it
Add related resources or links
Always respect the author’s intent
Don’t use edits to reply to the author

create code fences with backticks ` or tildes ~
```
like so
```
add language identifier to highlight code
```python
def function(foo):
print(foo)
```
put returns between paragraphs
for linebreak add 2 spaces at end
_italic_ or **bold**
indent code by 4 spaces
backtick escapes `like _so_`
quote by placing > at start of line
to make links (use https whenever possible)

<https://example.com>

[example](https://example.com)

<a href="https://example.com">example</a>

formatting help »
answering help »