Database Update

Question

I am using the follwing code to update a person's email and password in the db. I have a datagridview which has only one row. When I hit the Update button, nothing happens - the page is refreshed and the values in the textboxes go back to what they were before....the update is not working. Please help. Thanks!

protected void btnUpdateAccount_Click(object sender, EventArgs e)
{
    SqlConnection conn = new SqlConnection(GetConnectionString());

    string sql = "UPDATE Member SET [Email] = @email, [Password] = @password WHERE [MemberID] = '" + mem_id + "'";

    TextBox email = email = (TextBox)Gridview1.Rows[0].FindControl("user_email");
    TextBox password = (TextBox)Gridview1.Rows[0].FindControl("user_password");

    try
    {

        conn.Open();
        SqlCommand cmd = new SqlCommand(sql, conn);

        cmd.Parameters.Add("@email", SqlDbType.VarChar);
        cmd.Parameters.Add("@password", SqlDbType.VarChar);

        cmd.Parameters["@email"].Value = email.Text;
        cmd.Parameters["@password"].Value = password.Text;

        cmd.CommandType = CommandType.Text;
        cmd.ExecuteNonQuery();

    }
    catch (System.Data.SqlClient.SqlException ex)
    {

        string msg = "Insert Error: ";
        msg += ex.Message;
        throw new Exception(msg);
    }

    finally
    {
        conn.Close();
    }

}

have you tried doing a dataGridView.DataBind() after command execution ? — Bala R
– Bala R, Commented Feb 25, 2011 at 3:09
DO NOT SAVE A PASSWORD LIKE IN THE DATABASE LIKE THAT!! This is WRONG. Use bcrypt to hash the password, and store the hash in the database. When someone tries to log in, you hash again and compare the hashes. — Joel Coehoorn
– Joel Coehoorn, Commented Feb 25, 2011 at 3:10
What is the value of mem_id? Is there a reason you're not using a parameter for that as well? — rsbarro
– rsbarro, Commented Feb 25, 2011 at 3:11
You're already using parameters in your query - I would strongly recommend to also use one for the mem_id value! — marc_s
– marc_s, Commented Feb 25, 2011 at 5:52
cmd.ExecuteNonQuery(); it return an integer value, so you can put. int i = cmd.ExecuteNonQuery(); and see what it is returning, also you can use finally after try to make sure the db con is closed. here you are just using it in the catch which isnt good — safi
– safi, Commented Feb 25, 2011 at 11:10

safi · Accepted Answer · 2011-02-25 11:13:55Z

1

cmd.ExecuteNonQuery(); it return an integer value, so you can put. int i = cmd.ExecuteNonQuery(); and see what it is returning, also you can use finally after catch to make sure the db con is closed. here you are just using it in the catch, also try to put break point and see if the parameter are passed in correct way and follow it till the end. like

finally
        {
            if (con != null)
            {
                con.Close();
            }
        }

answered Feb 25, 2011 at 11:13

safi

3,7868 gold badges27 silver badges38 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Robbie Tapping Over a year ago

+1 for A very helpful comment in regards to SqlConnection and TryCatch Blocks

Smarthinker · Accepted Answer · 2011-02-25 04:28:03Z

0

You need to bind the data from database again to get the new changes. grid view .bind()

answered Feb 25, 2011 at 4:28

Smarthinker

1

Comments

Jemes · Accepted Answer · 2011-02-25 14:08:53Z

0

There are a number of things that could be happening.

1) The btnUpdateAccount_Click event is never raised. To fix this, make sure the asp:Button tag has an OnClick="btnUpdateAccount_Click" attribute set.
An exception is being thrown and that you're not noticing.
The database is being updated, but you did not load/bind the data again to display the updated values.

edited Feb 25, 2011 at 14:08

answered Feb 25, 2011 at 3:26

Jemes

2,84222 silver badges22 bronze badges

Comments

Robbie Tapping · Accepted Answer · 2011-02-27 01:11:22Z

0

Make sure to put in your PageLoad Clause

** Change Made ** As per @marc_s comment changed if(this.IsPostBack == true) to if(this.IsPostBack) this.IsPostBack is boolean.

if(this.IsPostBack)
{
//dont load page
}

edited Feb 27, 2011 at 1:11

answered Feb 25, 2011 at 3:09

Robbie Tapping

2,5561 gold badge17 silver badges18 bronze badges

1 Comment

marc_s Over a year ago

Actually, since IsPostBack already is a boolean, you could also use if(this.IsPostBack) and be done with it....

Collectives™ on Stack Overflow

Database Update

4 Answers 4

1 Comment

Comments

Comments

1 Comment

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

Comments

1 Comment

Linked

Related