Replacing a certain substring within a string - .Replace() method not working for me C#

Question

I am currently working on a program and need to use the .Replace() method to remove a certain substring from a string. However, the code just doesn't seem to be working.

Below is the code I am using:

if (filter.Contains("AND [Type]"))
        {
            String test = "AND [Type] = '" + type + "'";
            filter.Replace(test, "");
        }
        else if (filter.Contains("Type") == true)
        {
            String test = "[Type] = '" + type + "'";
            filter.Replace(test, "");
        }

I have debugged the code and when stepping through it String test is set to exactly what is contained within the filter - however the code just runs through attempts the replace method but leaves the filter unchanged.

Is there any other way I can attempt to get this working or do I need to take a few steps back and come up with another idea for getting this working?

strings in C# are immutable.

Dido
– Dido

2017-11-06 09:02:42 +00:00
Commented Nov 6, 2017 at 9:02 — Dido
– Dido, Commented Nov 6, 2017 at 9:02

apomene · Accepted Answer · 2017-11-06 09:00:54Z

3

You must assign the value to given string:

filter = filter.Replace(test, "");

Replace() returns a new string, more here

answered Nov 6, 2017 at 9:00

apomene

14.4k10 gold badges51 silver badges76 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

BugFinder · Accepted Answer · 2017-11-06 09:01:01Z

1

You need to set the replace to a variable so filter = filter.Replace(test, "");

Its a common issue with some of the functions like date adding hours, string replace..

answered Nov 6, 2017 at 9:01

BugFinder

17.9k4 gold badges42 silver badges58 bronze badges

2 Comments

benjiiiii Over a year ago

I knew this as well as I've used the method in another part of my code! I debugged for agers and didn't notice the simple error - Thanks!

BugFinder Over a year ago

@benjiiiii as I said, its a common mistake .. its easy to miss for that reason

Momo · Accepted Answer · 2017-11-06 09:02:05Z

0

Look at he function definition string.Replace returns your new string:

https://msdn.microsoft.com/de-de/library/fk49wtc1(v=vs.110).aspx

answered Nov 6, 2017 at 9:02

Momo

4841 gold badge6 silver badges22 bronze badges

Collectives™ on Stack Overflow

Replacing a certain substring within a string - .Replace() method not working for me C#

3 Answers 3

Comments

2 Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

2 Comments

Comments

Related