Argument 'testController' is not a : Angular

Question

I'm working on Salesforce Visualforce template and components, I have the below code embedded and I'm trying to fix the bug.

I did check the similar link here : AngularJS error: [ng:areq] Argument 'TestController' is not a function, got undefined

<div xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" ng-app="vsTestApp">
...
    <c:TestController />
    <c:TestTemplate />
...
</div>

The code for TestController

<apex:component >
<script>
(function() {
    'use strict';
    angular
    .module('vsTestApp', []);
}());

(function() {
    'use strict';
    angular
    .module('vsTestApp')
    .controller('testController', testController);

    testController.$inject = ['$filter', '$window' ,'$rootScope' ];

    function testController($filter, $window , $rootScope) {
        //Some Logic's Here
        function print() {
            $window.print();
        }
    }
}());
</script>
</apex:component>

The code for TestTemplate

<apex:component >
<script type="text/ng-template" id="vlcCompareModal.html">
    <a clasS="btn btn-default" ng-controller="testController as smallGroup"  ng-click="smallGroup.print()">Print</a>
</script>  
</apex:component>

I'm getting error saying Argument 'testController' is not a Link : https://docs.angularjs.org/error/ng/areq?p0=testController&p1=not%20a

Updated. I believe still the error exists. Thanks for the info. — Deepak Bandi
– Deepak Bandi, Commented Mar 21, 2017 at 18:12
@Aman what do you mean by that using that only will give you faster results? — Gonzalo.-
– Gonzalo.-, Commented Mar 21, 2017 at 18:15
@DeepakBandi I think you need to define your controller after $injecting dependencies. Like testController.$inject = ['$filter', '$window' ,'$rootScope' ]; and then app.controller('testController', testController) — Gonzalo.-
– Gonzalo.-, Commented Mar 21, 2017 at 18:24

Ben · Accepted Answer · 2017-03-21 18:21:48Z

1

Try defining your controller after the controller function:

(function() {
    'use strict';

     testController.$inject = ['$filter', '$window' ,'$rootScope'];

     function testController($filter, $window , $rootScope) {
         //Some Logic's Here
         function print() {
            $window.print();
         }
     }

     angular.module('vsTestApp')
         .controller('testController', testController);
}());

answered Mar 21, 2017 at 18:21

Ben

2,7261 gold badge15 silver badges16 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Gonzalo.- Over a year ago

since he's defining the controller as named function (and not using var testController = function(){..}) this isn't the problem

MattE · Accepted Answer · 2017-03-21 19:33:54Z

0

This is off topic but that is a mess.

Why would you simply not do:

.controller('testcontroller', ['$filter', $window', '$rootscope', function($filter, $windwo, $rootscope) {

}]);

Much more concise and easier to read and understand for others looking at your code.

answered Mar 21, 2017 at 19:33

MattE

1,1021 gold badge15 silver badges37 bronze badges

2 Comments

Deepak Bandi Over a year ago

Its a code which is already written and I'm trying to fix it.

FlavorScape Over a year ago

looks like somebody munged the typescript way of doing things and the vanilla way.

Stephane Janicaud · Accepted Answer · 2017-03-22 00:35:53Z

0

Shouldn't it be <c:testController /> instead of <c:TestController /> ?

answered Mar 22, 2017 at 0:35

Stephane Janicaud

3,7051 gold badge16 silver badges21 bronze badges

1 Comment

Deepak Bandi Over a year ago

It is the way filename is saved and the file name is TestController.

Collectives™ on Stack Overflow

Argument 'testController' is not a : Angular

3 Answers 3

1 Comment

2 Comments

1 Comment

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

2 Comments

1 Comment

Linked

Related