Nested for loop - batch Script

Question

Hello Batch File experts,

I wrote this piece of code which will print the Latest file version present in the folder in comparison to file name sent as argument, however these line seems to work accordingly when I remove the outer for loop, which I designed to loop as many time as CLI arguments.

FOR /f %%f IN ('DIR /b %%a.*.zip') DO @SET last=%%f
ECHO %last%

Full code :

cd C:\Users\batch\Desktop\test
chdir


set arg1=%1
set arg2=%2
set list=%arg1% %arg2%


(for %%a in (%list%) do (


FOR /f %%f IN ('DIR /b %%a.*.zip') DO @SET last=%%f

ECHO %last%

)) 

pause

what am I missing here because of which variable last is not set with value when outer loop is present which works perfectly without it.

Thanks,

The echoing of your variable is in the wrong place, you've got a variable named last which is only technically last at the end, not throughout. (it is technically only echoing every file and setting to the last modified matching file of the latest found argument). — Compo
– Compo, Commented Nov 30, 2016 at 13:39
Too many people use for loops as the default coding method with no thought as to possible alternatives, there's no reason why alternatives ignoring !last! or call %%last%% should not be proposed. — Compo
– Compo, Commented Nov 30, 2016 at 13:57

Compo · Accepted Answer · 2016-11-30 18:12:15Z

0

Might I suggest you use SHIFT instead:

@Echo Off
SetLocal
If %1'==' Exit/B
If /I Not "%CD%"=="%USERPROFILE%\Desktop\test" (
    PushD "%USERPROFILE%\Desktop\test" 2>Nul&&(Set _=PopD)||Exit/B)
:Loop
For %%A In ("%~1*.zip") Do Set "last=%%A"
Echo=%last%
Shift
If Not %1'==' GoTo Loop
%_%
EndLocal
Timeout -1

This of course means that you are free to use it with more than two arguments!

edited Nov 30, 2016 at 18:12

answered Nov 30, 2016 at 13:51

Compo

39k5 gold badges32 silver badges46 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Pavan Pothnis Over a year ago

Thanks for this solution, its exactly what I was looking. Now I will try to understand the logic.

Magoo · Accepted Answer · 2016-11-30 12:39:16Z

0

You need to use delayed expansion (about ten thousand SO items on this) or use a subroutine or

call echo %%last%%

answered Nov 30, 2016 at 12:39

Magoo

80.8k8 gold badges68 silver badges92 bronze badges

Collectives™ on Stack Overflow

Nested for loop - batch Script

2 Answers 2

1 Comment

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Linked

Related