Call a service from @ngModule

Question

I want to call a service imported in my @ngModule from a login component. This what i did but it's not working. I have just started to work on the A2 final version.

export class Login implements OnInit{
  constructor(
    private _service: Service
    ) {
  }
  ngOnInit() {
    this._service.login(value)
        .subscribe(x => console.log(x));
    }
  }
}

My @ngModule

import { NgModule } from '@angular/core';
import { RouterModule } from '@angular/router';
import { LoginService } from '../service/login.service'; 

import { Login } from './login.component';

export const routes = [
  { path: '', component: Login, pathMatch: 'full' }
];

@NgModule({
  declarations: [
    Login
  ],
  imports: [
    CommonModule,
    RouterModule.forChild(routes)
  ],
  providers: [LoginService]
})
export default class LoginModule {
  static routes = routes;
}

Any ideas ?

A hint from the style guide: "Avoid prefixing private properties and methods with an underscore." angular.io/guide/styleguide#style-03-04 — Zymotik
– Zymotik, Commented Aug 3, 2017 at 10:43

Pankaj Parkar · Accepted Answer · 2016-10-24 09:53:30Z

1

Inside constructor Service should be LoginService, as you wanted to access/create an instance of LoginService. Also make sure LoginService has been imported.

constructor(
   private _service: LoginService //<-- changed dependency type name
   ) {
}

answered Oct 24, 2016 at 9:53

Pankaj Parkar

136k23 gold badges241 silver badges307 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Adrien Castagliola Over a year ago

I get this : Error: Can't resolve all parameters for Login: (Router, ?).

Pankaj Parkar Over a year ago

@AdrienCastagliola do you have router-outlet directive on page..?

ranakrunal9 · Accepted Answer · 2016-10-24 09:53:50Z

1

Chage your component class to use LoginService

export class Login implements OnInit{
  constructor(
    private _service: LoginService
    ) {
  }
  ngOnInit() {
    this._service.login(value)
        .subscribe(x => console.log(x));
    }
  }
}

answered Oct 24, 2016 at 9:53

ranakrunal9

13.6k3 gold badges44 silver badges43 bronze badges

Comments

Igor Janković · Accepted Answer · 2016-10-24 09:55:02Z

0

You have to import LoginService in Login component also and add it to constructor as:

constructor( _service: LoginService) {  }

answered Oct 24, 2016 at 9:55

Igor Janković

5,5326 gold badges34 silver badges47 bronze badges

Collectives™ on Stack Overflow

Call a service from @ngModule

3 Answers 3

2 Comments

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

Comments

Related