Unable to deserialize string to dictionary<string,string>

Question

I am deserializing a string to Dictionary. Here is the code for deserialization:

public T Deserialize<T>(string serialized)
{
    var serializer = new DataContractSerializer(typeof(T));
    StringReader reader = null;
    try
    {
        reader = new StringReader(serialized);
        using (XmlTextReader stm = new XmlTextReader(reader))
        {
            reader = null;
            return (T)serializer.ReadObject(stm);
        }
    }
    finally
    {
        if (reader != null)
        {
            reader.Dispose();
        }
    }
}

This is how I am passing the input string :

string json = @"{""key1"":""value1"",""key2"":""value2""}";

However I get an error at the line ReadObject(stm) :

There was an error deserializing the object of type System.Collections.Generic.Dictionary`2[[System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089],[System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]]. Data at the root level is invalid. Line 1, position 1.

I have tried giving the input like this:

string json = "[{'key1':'value1','key2':'value2'}]";

But I am still getting the same error. What am I doing wrong?

Edit: I cannot change the Deserialize method as its a method written by my client. I am just writing the unit test for testing it.

what about string json = "['key1':'value1','key2':'value2']"; ? — Jakub Rusilko
– Jakub Rusilko, Commented Oct 26, 2015 at 13:45
I'm not familiar with the library but are you sure XmlTextReader deserializes JSON? — Casey
– Casey, Commented Oct 26, 2015 at 13:47
Why are you creating an XmlTextReader? Moreso, you don't seem to be using it at all. — Yuval Itzchakov
– Yuval Itzchakov, Commented Oct 26, 2015 at 13:48
Are you sure you're allowed to pass a JSON to your method? DataContractSerializer is used to serialize to XML, not JSON. — Yuval Itzchakov
– Yuval Itzchakov, Commented Oct 26, 2015 at 14:01

Yuval Itzchakov · Accepted Answer · 2015-10-26 14:15:29Z

5

Instead of jumping through all these hoops and using DataContractSerializer and creating custom logic to parse json, I advise you to look into Json.NET, which makes this a joy:

string json = @"{""key1"":""value1"",""key2"":""value2""}";
var dictionary = JsonConvert.DeserializeObject<Dictionary<string, string>>(json);

Edit:

It looks as if you're trying to pass a JSON to a method that can only parse XML strings. I advise you ask your client provider what acceptable inputs can be used.

edited Oct 26, 2015 at 14:15

answered Oct 26, 2015 at 13:49

Yuval Itzchakov

150k32 gold badges275 silver badges333 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

nitinvertigo Over a year ago

Please take a look at the edit I made to the question

Casey Over a year ago

@nitinvertigo Well, you could either use XML in the first place or else JSON.NET does support conversion: newtonsoft.com/json/help/html/convertingjsonandxml.htm

Amit Kumar Ghosh · Accepted Answer · 2015-10-26 14:25:40Z

0

You could try this -

string json = @"{""key1"":""value1"",""key2"":""value2""}";
var o = new DataContractJsonSerializer(typeof(T));
var mem = new MemoryStream(UTF32Encoding.UTF8.GetBytes(new StreamReader(json.ToCharArray()));
mem.Position = 0;
var o2 = o.ReadObject(mem);

public class T
{
    public string key1 { get; set; }
    public string key2 { get; set; }
}

answered Oct 26, 2015 at 14:25

Amit Kumar Ghosh

3,7761 gold badge22 silver badges24 bronze badges

1 Comment

nitinvertigo Over a year ago

pls see the edit part of my question...I cannot change the deserialize method. I just wanted to know the correct format of input for the above deserialize method

Collectives™ on Stack Overflow

Unable to deserialize string to dictionary<string,string>

2 Answers 2

2 Comments

1 Comment

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Linked

Related