Make python code continue after exception

Question

I'm trying to read all files from a folder that matches a certain criteria. My program crashes once I have an exception raised. I am trying to continue even if there's an exception but it still stops executing.

This is what I get after a couple of seconds.

error <type 'exceptions.IOError'>

Here's my code

import os 
path = 'Y:\\Files\\'
listing = os.listdir(path)
try:
    for infile in listing:
        if infile.startswith("ABC"):
            fo = open(infile,"r")
            for line in fo:
                if line.startswith("REVIEW"):
                    print infile
            fo.close()
except:
    print "error "+str(IOError)
    pass

"I am trying to continue even if there's an exception"- never do this unless you have a clear plan for how your program should continue. Assuming that your code after the except: block relies on the file contents, continuing on after an IO error is a bad idea. Let the exception crash the program instead, so that you can actually notice and fix the underlying problem. — musical_coder
– musical_coder, Commented Sep 25, 2013 at 0:52
Beside the point, but a bare except is bad practice. Instead, use the specific exception you're expecting like except IOError, or at least except Exception. — wjandrea
– wjandrea, Commented Aug 11, 2022 at 17:34

TerryA · Accepted Answer · 2013-09-25 00:35:52Z

Put your try/except structure more in-wards. Otherwise when you get an error, it will break all the loops.

Perhaps after the first for-loop, add the try/except. Then if an error is raised, it will continue with the next file.

for infile in listing:
    try:
        if infile.startswith("ABC"):
            fo = open(infile,"r")
            for line in fo:
                if line.startswith("REVIEW"):
                    print infile
            fo.close()
    except:
        pass

This is a perfect example of why you should use a with statement here to open files. When you open the file using open(), but an error is catched, the file will remain open forever. Now is better than never.

for infile in listing:
    try:
        if infile.startswith("ABC"):
            with open(infile,"r") as fo
                for line in fo:
                    if line.startswith("REVIEW"):
                        print infile
    except:
        pass

Now if an error is caught, the file will be closed, as that is what the with statement does.

Brendan Long · Accepted Answer · 2013-09-25 00:36:08Z

12

You're code is doing exactly what you're telling it to do. When you get an exception, it jumps down to this section:

except:
    print "error "+str(IOError)
    pass

Since there's nothing after that, the program ends.

Also, that pass is superfluous.

answered Sep 25, 2013 at 0:36

Brendan Long

54.5k21 gold badges153 silver badges194 bronze badges

1 Comment

Brendan Long Over a year ago

@Ankur pass means "do nothing". Your code will continue without it. The problem is that there's nothing for it to do after your except block.

Rami · Accepted Answer · 2013-11-09 01:38:02Z

11

Move the try/except inside the for loop. Like in:

  import os 
    path = 'C:\\'
    listing = os.listdir(path)
    for infile in listing:
        try:    
            if infile.startswith("ABC"):
                fo = open(infile,"r")
                for line in fo:
                    if line.startswith("REVIEW"):
                        print infile
                fo.close()
        except:
              print "error "+str(IOError)

edited Nov 9, 2013 at 1:38

answered Sep 25, 2013 at 0:40

Rami

7,3201 gold badge24 silver badges21 bronze badges

Comments

Jose Urena · Accepted Answer · 2023-02-05 23:48:17Z

As per strictest interpretation of the question "continue even if there's an exception". Python gives us a keyword "finally" which executes a block of code no matter what precedes it. The only issue with this method will run a block of code regardless of the type of error, which might not be desirable for all cases.

try:
  unreal = 3/0 # raises divide by zero exception
  print(unreal)

# handles zerodivision exception
except :
  print("Can't divide by zero, 0 has no multiplicative inverse")

finally:
# this block is always executed
  print("Brahmagupta claimed that “zero divided by a zero is zero.”)

Collectives™ on Stack Overflow

Make python code continue after exception

4 Answers 4

Comments

1 Comment

Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

1 Comment

Comments

Comments

Linked

Related