Forms Collection when submitting

Question

What is the best practice for submitting forms in ASP.NET MVC? I have been doing code like this below, but I have a feeling there is a better way.

    [AcceptVerbs(HttpVerbs.Post)]
    public ActionResult AddNewLink(FormCollection collection_)
    {
        string url = collection_["url"].ToString();
        string description = collection_["description"].ToString();
        string tagsString = collection_["tags"].ToString();
        string[] tags = tagsString.Replace(" ","").Split(',');

        linkRepository.AddLink(url, description, tags);

Blake Pettersson · Accepted Answer · 2009-09-08 00:09:52Z

You can use the parameters directly; the parameters will automatically get parsed and casted to its correct type. The parameter names in the method must match the parameter names that are posted from your form.

[AcceptVerbs(HttpVerbs.Post)]
public ActionResult AddNewLink(string url, string description, string tagsString)
{
    string[] tags = tagsString.Replace(" ","").Split(',');

    linkRepository.AddLink(url, description, tags);
}

This generally works on more complex objects as well, as long as its properties can be set, and as long as your form keys are in the format objectName.PropertyName. If you need anything more advanced, you should look into model binders.

public class MyObject
{
    public int Id {get; set;}
    public string Text {get; set;}
}

[AcceptVerbs(HttpVerbs.Post)]
public ActionResult AddNewLink(MyObject obj)
{
    string[] tags = obj.Text.Replace(" ","").Split(',');

    linkRepository.AddLink(url, description, tags);
}

Jirapong · Accepted Answer · 2009-09-08 00:30:46Z

In my opinion, the Model Binder is cleaner. You can learn more at OdeToCode.com

Basically, You wrap your input from a FormCollection to a desirable model as well as validation.

public class LinkModelBinder : IModelBinder
{
    public object BindModel(ControllerContext controllerContext, ModelBindingContext bindingContext)
    {
        var link = new Link();
        link.Url = GetValue<string>(bindingContext, "url");
        // ... and so on for all properties

        if (String.IsNullOrEmpty(url.Name))
        {
            bindingContext.ModelState.AddModelError("Url", "...");
        }

        return link;
    }

    private T GetValue<T>(ModelBindingContext bindingContext, string key) 
    {
        ValueProviderResult valueResult;
        bindingContext.ValueProvider.TryGetValue(key, out valueResult);            
        return (T)valueResult.ConvertTo(typeof(T));
    }  
}

In the controller

public ActionResult AddNewLink(Link link)

Collectives™ on Stack Overflow

Forms Collection when submitting

2 Answers 2

Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Linked

Related