PHP / MYSQL - Can't get ID for each entry

Question

I am at scripting a customer database. When I wanted to implement the "manage customers" site where you can edit, delete and view details of each entry, I encountered a strange problem. Everything works like expected, but the ID field is left empty and added nowhere.

I have the following code:

    <?php
$qresult = mysql_query("SELECT ID , FirstName, LastName, Company FROM hs_customers");

echo "<table class='coverview' border='0' width='100%' cellpadding='0' cellspacing='0'>";
echo "<th>FirstName</th>
      <th>LastName</th>
      <th>Company</th>
      <th>Options</th>";

while($row = mysql_fetch_array($qresult))
{
echo "<tr>";
echo "<td>" . $row['FirstName'] . "</td>" . 
     "<td>" . $row['LastName'] . "</td>" . 
     "<td>" . $row['Company'] . "</td>" . 
     "<td>" . "<a href='?action=details&id='" . $row['ID'] . "'>Details</a>" .     " " . 
     "<a href='?action=edit&id='" . $row['ID'] . "'>Edit</a>" . " " . 
     "<a href='?action=delete&id='" . $row['ID'] . "'>Delete</a>" . "</td>";
echo "</tr>";
}
echo "</table>";

mysql_close($con);

?>

as far as I can see, you are selecting an ID field, and using uid on the rows — guiligan
– guiligan, Commented Sep 13, 2012 at 12:05
Why do people say its, "so bad." It's still in use today on older systems and is still functional. I have a project I built years ago that uses mysql functions and performs very well to this day. As shown on this post, the main advantage of mysqli vs mysql is that it uses prepared statements stackoverflow.com/questions/548986/mysql-vs-mysqli-in-php. If you're not using those, then you shouldn't encounter any issues... — user1477388
– user1477388, Commented Sep 13, 2012 at 14:03

DonCallisto · Accepted Answer · 2012-09-13 12:12:10Z

5

You use $row['uid'] but you select ID from your query, so should be row['ID']

Moreover, don't use anymore function like mysql_query. As you can read here is discouraged. Please use msqli instead.

The best solution is to use PDO. Please take a look to them too.

edited Sep 13, 2012 at 12:12

answered Sep 13, 2012 at 12:05

DonCallisto

30k9 gold badges74 silver badges104 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

tftd Over a year ago

It's even better if he uses PDO instead of mysqli.

Dreshar Over a year ago

Thank you for your replies. @DonCallisto - i was using ID too i forgot to edit it back while posting it here - still same result. I didn't knew that this is obsolete. Thank you for the tip ;)

Sudhir Bastakoti · Accepted Answer · 2012-09-13 12:05:30Z

2

shouldnt it be:

$row['ID']

instead of

$row['uid']

answered Sep 13, 2012 at 12:05

Sudhir Bastakoti

100k15 gold badges163 silver badges169 bronze badges

Comments

Mathlight · Accepted Answer · 2012-09-13 12:05:44Z

1

You echo

$row['uid']

But your Selecting from de database:

$row['ID']

answered Sep 13, 2012 at 12:05

Mathlight

6,72318 gold badges66 silver badges109 bronze badges

Comments

newfurniturey · Accepted Answer · 2012-10-02 03:50:09Z

1

Well I guess it's just because you use $row['uid'] but in your SQL query you're using ID. You should be using $row['ID'] instead.

edited Oct 2, 2012 at 3:50

newfurniturey

38.6k10 gold badges99 silver badges104 bronze badges

answered Sep 13, 2012 at 12:06

RemyG

4965 silver badges11 bronze badges

Collectives™ on Stack Overflow

PHP / MYSQL - Can't get ID for each entry

4 Answers 4

2 Comments

Comments

Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

Comments

Comments

Comments

Linked

Related