Pass PHP Variable into Java Script window.location

Question

I am trying to pass a php variable into a java script window.location that returns a user to the current list view after deleting an item from the database. I can't seem to get the syntax correct.

Code:

function confirmation(a) {
var currString = "<? echo $currString ?>";
var answer = confirm("Are you sure you want to delete this item?")
if (answer){
    alert("The item has been deleted")
    window.location = "list.php?s='. $currString .'&=delete=true&id=" + a;
}
else{
    alert("The item has not been deleted")
}

Parth Thakkar · Accepted Answer · 2012-08-31 15:52:07Z

10

Try this:

function confirmation(a) {
    var currString = "<?php echo $currString ?>";
    var answer = confirm("Are you sure you want to delete this item?");
    if (answer){
        alert("The item has been deleted")
        window.location = "list.php?s=" + currString + "&=delete=true&id=" + a;
    }
    else{
        alert("The item has not been deleted");
}

edited Aug 31, 2012 at 15:52

answered Jun 20, 2012 at 15:19

Parth Thakkar

5,4753 gold badges29 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

8 Comments

Rey Gonzales Over a year ago

Yaw, the concatenation operator is mixed up. As well as misplacing quotes.

pixelJockey Over a year ago

It seems the code fails to open the alert window. My delete button does nothing.

pixelJockey Over a year ago

Sorry it does work. It was missing/needed an additional "}". I failed to copy that the first time.

pixelJockey Over a year ago

One last question. Now the alert is working but it doesn't actually delete the entry from the database. This function was working...if(isset($_GET['delete'])) { $id = $_GET['id']; mysql_query("DELETE FROM resources WHERE id = $id LIMIT 1"); }

Parth Thakkar Over a year ago

sorry man, no idea! But the request is made right? Maybe some problem with server side. No idea about that right now. :)

|

Khurram · Accepted Answer · 2012-06-20 15:26:37Z

1

you are pasing php variable to JS variable var currString = "";

and in window.location you are passing again php variable which is wrong,

so do it like this

window.location = "list.php?s=" + currString + "&=delete=true&id=" + a;

answered Jun 20, 2012 at 15:26

Khurram

6865 silver badges10 bronze badges

Comments

Jasper de Vries · Accepted Answer · 2012-08-29 07:36:52Z

1

The syntax issue was solved by other answers, but you need to take care of an additional issue: URI encoding your variable when you use it in the URL:

window.location = "list.php?s="
                + encodeURIComponent(currString)
                + "&=delete=true&id=" + a;

or else you will run into problems of your variable contains characters like &.

answered Aug 29, 2012 at 7:36

Jasper de Vries

20.4k6 gold badges68 silver badges107 bronze badges

Comments

Bart · Accepted Answer · 2012-08-29 08:38:23Z

-3

echo "<script>alert('System info has been Save')</script>";
echo "<script>window.location='customer_detail.php?
customer_id=".$customer_id."'</script>";

edited Aug 29, 2012 at 8:38

Bart

20.1k8 gold badges72 silver badges80 bronze badges

answered Aug 29, 2012 at 7:21

sanjay guptya

1

1 Comment

msEmmaMays Over a year ago

This has typos in the code, you are missing two ; in the echoed javascript

Collectives™ on Stack Overflow

Pass PHP Variable into Java Script window.location

4 Answers 4

8 Comments

Comments

Comments

1 Comment

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

8 Comments

Comments

Comments

1 Comment

Linked

Related