Menu

#569 (ok 3.5) XML plugin for database export

Work_in_progress
closed-accepted
1
2012-04-07
2010-12-12
Aamir Khan
No

BUG#ID: 3076692
Previously the structure schema for database was not getting exported. Hence only the tables having some rows in it and listed in <database> section gets exported...Edited and rectified the structure schemas checkbox for XML exporting

Discussion

  • Aamir Khan

    Aamir Khan - 2010-12-12

    edited file libraries/export/xml.php

     
  • Aamir Khan

    Aamir Khan - 2010-12-12
    • assigned_to: nobody --> ruleant
     
  • Dieter Adriaenssens

    Thanks for submitting the patch. It enables the structure schema for tables, views, routines, functions, ... but it also introduces some bugs, that recently have been solved for the SQL export option :

    * bug #1762306, #1672099 : export view of view (when the view referenced by another view is not defined first, the import throws an error)
    * bug #3062455 : functions/routines should be exported before tables/views (because an error might occur when importing a view that uses a routine/function, before it is defined)

    So I think that the mentioned known bugs (which apply to exporting/importing xml as well) should be solved before enabling the 'export structure schema' option.

     
  • Dieter Adriaenssens

    • milestone: 284142 --> Work_in_progress
     
  • Aamir Khan

    Aamir Khan - 2010-12-13

    i looked at these bugs...but these are already solved in repository earlier and the option for exporting the structure schema was present at that time ( atleast present in 3.3.8 ) .... do these bugs exist for 3.3.8 release? if not, then they should not appear now as well ... since i have just added option for schema export and it was present in case of stable previous stable release.

     
  • Dieter Adriaenssens

    Yes, the mentioned bugs are solved (for SQL export). What I meant to say, is that the similar bugs are also present for XML export, and that these should be solved before adding the schema export option, at least in a stable release.
    It's true that schema export was enabled for SQL export, before those bugs were solved, but they were not known at that moment, and now they are, so I guess it makes sense to solve them before enabling the functionality of exporting the schema structure.
    I will create two bugs for it.

     
  • Dieter Adriaenssens

    Your patch was merged in the repository, thanks.

     
  • Dieter Adriaenssens

    • summary: XML plugin for database export --> (ok 3.5-dev) XML plugin for database export
    • priority: 5 --> 1
    • status: open --> open-accepted
     
  • Dieter Adriaenssens

    currently in branch xml_export

     
  • Dieter Adriaenssens

    • summary: (ok 3.5-dev) XML plugin for database export --> (ok 3.5) XML plugin for database export
     
  • Aamir Khan

    Aamir Khan - 2010-12-14

    functions/routines are exported first

     
  • Aamir Khan

    Aamir Khan - 2010-12-14

    Ptach for bugs ID : 3136658 & 3136655 & 3076692

     
  • Aamir Khan

    Aamir Khan - 2010-12-14

    Patch added to rectify whole XML export

     
  • Dieter Adriaenssens

    xml-export.diff (functions/routines should be exported first) is added to branch xml_export.

    Remarks :
    * removed whitespace before committing, please make sure no unnecessary whitespace is in the beginning of lines when sending a patch.
    * enabling the 'schema structure' option was done in a previous patch, removed this part of the fix.

     
  • Dieter Adriaenssens

    • priority: 1 --> 5
    • summary: (ok 3.5) XML plugin for database export --> XML plugin for database export
     
  • Dieter Adriaenssens

    export-xml-3-bugs-patch.diff (Ptach for bugs ID : 3136658 & 3136655 & 3076692), could you resolve these issues and submit the patch again?

    * remove unnecessary whitespace
    * only submit one fix per patch :
    ** fixing typo in sql.php should go in a different patch/commit
    ** checkout branch xml_export and make your diff from that point (previous fixes should not accumulate in every new patch file)

    BTW: instructions on how to checkout a different branch than master are here : http://wiki.phpmyadmin.net/pma/Devel:Git#Working_with_branches

     
  • Dieter Adriaenssens

    • priority: 5 --> 1
    • summary: XML plugin for database export --> (ok 3.5) XML plugin for database export
     
  • Marc Delisle

    Marc Delisle - 2012-04-07
    • status: open-accepted --> closed-accepted