FLAC-Free Lossless Audio Codec / Bugs / #125 --skip=mm:ss.ss 'skips' the fractions of a second

#125 --skip=mm:ss.ss 'skips' the fractions of a second

Status: closed-fixed

Owner: Josh Coalson

Labels: flac (command-line) (139)

Priority: 6

Updated: 2006-11-14

Created: 2004-09-20

Creator: Anonymous

Private: No

Compiling flac-1.1.1-beta1 from source on Linux, "make
check" reported 1 failed test. The culprit turned out
to be test/test_flac.sh which dies on line 271 ["ERROR:
file mismatch for --skip=0:01.1001 (encode) (raw<->flac)"].

Fast-forwarding ahead, it looks like the problem lies
in the atof call on line 78 of src/flac/utils.c
(function local__parse_timecode_). I'm using a locale
where the decimal-point character is a comma and I
assume atof is expecting "01,1001" instead of
"01.1001". flac however doesn't like that form and
reports it as an invalid value (twice), so at the
moment that functionality is broken. Also, since
"xx.yy" just gets truncated to "xx" instead of failing,
it might go unnoticed for people who are using that
form of --skip.

-- menage71 at yahoo dot com

Discussion

Josh Coalson - 2004-10-15

assigned_to: nobody --> jcoalson
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Josh Coalson - 2006-11-13

priority: 5 --> 6

status: open --> open-accepted
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Josh Coalson - 2006-11-14

status: open-accepted --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Josh Coalson - 2006-11-14

Logged In: YES
user_id=78173

OK, fixed in CVS, thanks.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

--skip=mm:ss.ss 'skips' the fractions of a second

Group

Searches

Help

#125 --skip=mm:ss.ss 'skips' the fractions of a second

Discussion