| commit | fa709b850bf3e63e1f8feea7c911b15368997b8b | |
| author | Lucian Wischik <[email protected]> | |
| Sat, 20 Mar 2021 23:48:32 +0000 (20 16:48 -0700) | ||
| committer | Facebook GitHub Bot <[email protected]> | |
| Sat, 20 Mar 2021 23:49:46 +0000 (20 16:49 -0700) | ||
| tree | 2806caffe77259683af76568eb243a61ef39892d | treesnapshot (tar.gz zip) |
| parent | c8672d0625c58e5af1f8e44acc89b0edb1a2ab81 | commitdiff |
remove unused import
Summary:
This file gives "warning: unused import: `ocamlrep::rc::RcOc`"
It started giving that warning ever since D27154091 (https://github.com/facebook/hhvm/commit/2319dfcc38f366de0b0ec2f7d21752bf39fc33d0), which removed the last use of it.
Say, shiqicao, I have a question about that diff. Its summary says "we don't need to copy env anymore. The diff removes the call to make_env from hhbc/emit_memoize_method.rs. But why didn't it also remove the exact same call from hhbc_by_ref/emit_memoize_method.rs ?
Reviewed By: bobrenjc93
Differential Revision: D27209219
fbshipit-source-id: d7a1da5febe0bfa40fff3053fecbc2abd6a885cf
Summary:
This file gives "warning: unused import: `ocamlrep::rc::RcOc`"
It started giving that warning ever since D27154091 (https://github.com/facebook/hhvm/commit/2319dfcc38f366de0b0ec2f7d21752bf39fc33d0), which removed the last use of it.
Say, shiqicao, I have a question about that diff. Its summary says "we don't need to copy env anymore. The diff removes the call to make_env from hhbc/emit_memoize_method.rs. But why didn't it also remove the exact same call from hhbc_by_ref/emit_memoize_method.rs ?
Reviewed By: bobrenjc93
Differential Revision: D27209219
fbshipit-source-id: d7a1da5febe0bfa40fff3053fecbc2abd6a885cf
| hphp/hack/Cargo.lock | diffblobblamehistory | |
| hphp/hack/src/hhbc/cargo/emit_memoize_method/Cargo.toml | diffblobblamehistory | |
| hphp/hack/src/hhbc/emit_memoize_method.rs | diffblobblamehistory |