| commit | cdd59044da64fd5381cc4f43484fca6c5c9bb7f1 | |
| author | Mark Williams <[email protected]> | |
| Thu, 10 Oct 2019 01:54:23 +0000 (9 18:54 -0700) | ||
| committer | Facebook Github Bot <[email protected]> | |
| Thu, 10 Oct 2019 01:56:58 +0000 (9 18:56 -0700) | ||
| tree | 446f681973e686a6542cd78d91092e6996aee702 | treesnapshot (tar.gz zip) |
| parent | 3874276c14716b4e4cd2bb127d8160638867346a | commitdiff |
Speed up compute_interface_vtables
Summary:
A while ago, I moved compute_interface_vtables to a separate thread so
it wouldn't slow the build (by much). I've just noticed that it
sometimes runs much longer than the steps it runs in parallel with,
and after investigating, found that building the conflict graph was
O(n^2). Fix that by using std::unordered_set instead of std::vector.
Reviewed By: ricklavoie, binliu19
Differential Revision: D17817227
fbshipit-source-id: 6be38519989807541b4913ea129ad513047f30b8
Summary:
A while ago, I moved compute_interface_vtables to a separate thread so
it wouldn't slow the build (by much). I've just noticed that it
sometimes runs much longer than the steps it runs in parallel with,
and after investigating, found that building the conflict graph was
O(n^2). Fix that by using std::unordered_set instead of std::vector.
Reviewed By: ricklavoie, binliu19
Differential Revision: D17817227
fbshipit-source-id: 6be38519989807541b4913ea129ad513047f30b8
| hphp/hhbbc/index.cpp | diffblobblamehistory |