| commit | 74b07f41c61a1ec756c86ca6638e9a5bc1fcd422 | |
| author | Shaunak Kishore <[email protected]> | |
| Mon, 7 Dec 2020 02:20:11 +0000 (6 18:20 -0800) | ||
| committer | Facebook GitHub Bot <[email protected]> | |
| Mon, 7 Dec 2020 02:23:26 +0000 (6 18:23 -0800) | ||
| tree | eb33fb47f44f4a796da1fa49e39ce6627b60b4cb | treesnapshot (tar.gz zip) |
| parent | 74be79e9812040d66e0a428ce0d2612edc1425f4 | commitdiff |
Use a vanilla layout at unsampled sinks
Summary:
All "unsampled" arrays are coming from sources that we don't know how to convert to bespoke sources. As such, we should choose vanilla for them.
If a given sink only sees unsampled arrays, we'll already make it a vanilla sink. However, if it seems a very small number of sampled arrays, we'll currently make it a top sink. Fix that logic.
Reviewed By: oulgen
Differential Revision: D25362204
fbshipit-source-id: 4dc41c8a870be15187552ec259107cd91653f270
Summary:
All "unsampled" arrays are coming from sources that we don't know how to convert to bespoke sources. As such, we should choose vanilla for them.
If a given sink only sees unsampled arrays, we'll already make it a vanilla sink. However, if it seems a very small number of sampled arrays, we'll currently make it a top sink. Fix that logic.
Reviewed By: oulgen
Differential Revision: D25362204
fbshipit-source-id: 4dc41c8a870be15187552ec259107cd91653f270
| hphp/runtime/base/bespoke/layout-selection.cpp | diffblobblamehistory |