| commit | 5b48b9a312a56e0f3210d2bf1e10d64a7a96d67f | |
| author | Jeff Hemphill <[email protected]> | |
| Sat, 21 Mar 2020 02:18:07 +0000 (20 19:18 -0700) | ||
| committer | Facebook GitHub Bot <[email protected]> | |
| Sat, 21 Mar 2020 05:09:07 +0000 (20 22:09 -0700) | ||
| tree | 30cd4405354715a94414e36afcffe4848772f4be | treesnapshot (tar.gz zip) |
| parent | c4c09df65ff0081bcb467c7e2410e0beabe8ae4b | commitdiff |
Remove immediate sync check from ext_watchman.php test
Summary:
This seems to be the simplest cause of `ext_watchman.php` failures:
* https://our.intern.facebook.com/intern/testinfra/diagnostics/3377699742425470.281474985857212.1584586577/
* https://our.intern.facebook.com/intern/testinfra/diagnostics/6192449497039348.281474985857212.1584725653/
* https://our.intern.facebook.com/intern/testinfra/diagnostics/3659174719153127.281474985857212.1584596326/
```
034+ FAIL
034- PASS
```
We're asking Watchman to respond within 1 millisecond, but Watchman doesn't guarantee sub-millisecond responses, even if we just completed a sync successfully. I think we should just remove this check.
Reviewed By: DavidSnider
Differential Revision: D20572287
fbshipit-source-id: e1b2085ab014a07de5deada275710fc5b3a44767
Summary:
This seems to be the simplest cause of `ext_watchman.php` failures:
* https://our.intern.facebook.com/intern/testinfra/diagnostics/3377699742425470.281474985857212.1584586577/
* https://our.intern.facebook.com/intern/testinfra/diagnostics/6192449497039348.281474985857212.1584725653/
* https://our.intern.facebook.com/intern/testinfra/diagnostics/3659174719153127.281474985857212.1584596326/
```
034+ FAIL
034- PASS
```
We're asking Watchman to respond within 1 millisecond, but Watchman doesn't guarantee sub-millisecond responses, even if we just completed a sync successfully. I think we should just remove this check.
Reviewed By: DavidSnider
Differential Revision: D20572287
fbshipit-source-id: e1b2085ab014a07de5deada275710fc5b3a44767
| hphp/test/slow/ext_watchman/ext_watchman.php | diffblobblamehistory | |
| hphp/test/slow/ext_watchman/ext_watchman.php.expectf | diffblobblamehistory |