Promote invalid primitive aliasing to a parse errornightly-2019.09.26
commit330e14965cbf822d23c89fcd53076d8e0f1dce13
authorKunal Mehta <[email protected]>
Thu, 26 Sep 2019 02:09:02 +0000 (25 19:09 -0700)
committerFacebook Github Bot <[email protected]>
Thu, 26 Sep 2019 02:11:17 +0000 (25 19:11 -0700)
tree48120ff72a31858aba16dee741ad0010bfe166f3
parent7d8202d765c36f165c0c9c811e54c870190ba15a
Promote invalid primitive aliasing to a parse error

Summary: The previous diff codemodded all instances of this in systemlib to the canonical versions. This promotes the typechecker error to a parse error and removes the aliasing behavior from the typechecker and compiler.

Reviewed By: oulgen, alexeyt

Differential Revision: D17537778

fbshipit-source-id: 5cf39bfc8cedbcc35007cbfa21fc3b712fa3ab29
28 files changed:
hphp/hack/src/hhbc/emit_expression.ml
hphp/hack/src/naming/naming.ml
hphp/hack/src/naming/naming_special_names.ml
hphp/hack/src/naming/naming_special_names.rs
hphp/hack/src/parser/full_fidelity_ast.ml
hphp/hack/src/parser/full_fidelity_syntax_error.ml
hphp/hack/src/parser/full_fidelity_syntax_error.mli
hphp/hack/src/parser/hh_autoimport.ml
hphp/hack/src/parser/hh_autoimport.rs
hphp/hack/test/typecheck/double_argument.php.exp
hphp/hack/test/typecheck/double_cast.php.exp
hphp/hack/test/typecheck/real_return_type.php.exp
hphp/hack/test/typecheck/use_boolean_instead_of_bool.php.exp
hphp/hack/test/typecheck/use_integer_instead_of_int.php.exp
hphp/test/slow/parser/hh-reserved-name-real-1.php.expectf
hphp/test/slow/parser/hh-reserved-name-real-2.php.expectf
hphp/test/slow/parser/php-reserved-name-real-1.php [deleted file]
hphp/test/slow/parser/php-reserved-name-real-1.php.expect [deleted file]
hphp/test/slow/parser/php-reserved-name-real-2.php [deleted file]
hphp/test/slow/parser/php-reserved-name-real-2.php.expectf [deleted file]
hphp/test/slow/phpism/primitive_alias_boolean.php [new file with mode: 0644]
hphp/test/slow/phpism/primitive_alias_boolean.php.expectf [new file with mode: 0644]
hphp/test/slow/phpism/primitive_alias_double.php [new file with mode: 0644]
hphp/test/slow/phpism/primitive_alias_double.php.expectf [new file with mode: 0644]
hphp/test/slow/phpism/primitive_alias_integer.php [new file with mode: 0644]
hphp/test/slow/phpism/primitive_alias_integer.php.expectf [new file with mode: 0644]
hphp/test/slow/phpism/primitive_alias_real.php [new file with mode: 0644]
hphp/test/slow/phpism/primitive_alias_real.php.expectf [new file with mode: 0644]