| commit | 30ad813486c75cc4944fbab458c1306ba21b7c14 | |
| author | Young Kim <[email protected]> | |
| Fri, 2 Aug 2019 00:29:22 +0000 (1 17:29 -0700) | ||
| committer | Hhvm Bot <[email protected]> | |
| Fri, 2 Aug 2019 00:33:49 +0000 (1 17:33 -0700) | ||
| tree | e82a36219caf60d202451174576bb6b170396b58 | treesnapshot (tar.gz zip) |
| parent | f78c193efbe55e4bf86d77355cefe22a1daf3cf7 | commitdiff |
Use Hh_bucket in [next] and deprecate [inputs]
Summary:
As per Julia's suggestion in D16570870, use `Hh_bucket` to represent inputs. This accounts for the situation where not all workers have completed, and we want to keep workers alive until all work is **completed**, and not **pending**.
The logic to handle this isn't implemented yet (it'll be implemented later in the stack).
To summarize this diff, `next` has its signature changed to the following, and `inputs` has been deprecated.
```
type next = monitor_env -> monitor_env * 'input Hack_bucket.bucket
```
For more info, refer to D16605374 for all of the upcoming changes :)
Reviewed By: jewelpit
Differential Revision: D16610377
fbshipit-source-id: bca047af454e97f4d8297e6bd592b4ab08b8bd2f
Summary:
As per Julia's suggestion in D16570870, use `Hh_bucket` to represent inputs. This accounts for the situation where not all workers have completed, and we want to keep workers alive until all work is **completed**, and not **pending**.
The logic to handle this isn't implemented yet (it'll be implemented later in the stack).
To summarize this diff, `next` has its signature changed to the following, and `inputs` has been deprecated.
```
type next = monitor_env -> monitor_env * 'input Hack_bucket.bucket
```
For more info, refer to D16605374 for all of the upcoming changes :)
Reviewed By: jewelpit
Differential Revision: D16610377
fbshipit-source-id: bca047af454e97f4d8297e6bd592b4ab08b8bd2f
| hphp/hack/src/stubs/shared_lru.ml | diffblobblamehistory | |
| hphp/hack/src/typing/typing_lru_check_service.ml | diffblobblamehistory |