Revert `check_kind_to_string` to return variant namesnightly-2020.07.07
commit2dd791204c57ef01173cda77a02dcad1759a9fbb
authorTatiana Racheva <[email protected]>
Tue, 7 Jul 2020 01:42:48 +0000 (6 18:42 -0700)
committerFacebook GitHub Bot <[email protected]>
Tue, 7 Jul 2020 01:49:53 +0000 (6 18:49 -0700)
tree3d9e1f0185e6ab5c2ead80569170db229e08f895
parentcd3f88345260eb843428f9ee95ee3a33e3533ce2
Revert `check_kind_to_string` to return variant names

Summary:
This function was meant to be an enum/variant `to_string` function, but it was also used in logging, which was confusing.

This diff reverts the `to_string` function to return just the variant constructor names, and changes the logging to use the strings from the previous diff directly.

Reviewed By: ljw1004

Differential Revision: D22402531

fbshipit-source-id: dfb118002a678f61ec8407d888e9eba5893fa302
hphp/hack/src/server/serverTypeCheck.ml