| commit | 2cf86a75d15d40a20d1fc9086bffaf83c5e694d5 | |
| author | Shaunak Kishore <[email protected]> | |
| Fri, 1 Jan 2021 05:28:26 +0000 (31 21:28 -0800) | ||
| committer | Facebook GitHub Bot <[email protected]> | |
| Fri, 1 Jan 2021 05:30:09 +0000 (31 21:30 -0800) | ||
| tree | 31bd56703151fe527de06f5702d793ab8e89f058 | treesnapshot (tar.gz zip) |
| parent | 5062ba645036749011851939cf1c8ca953e6db21 | commitdiff |
Use consistent names for StaticMultiProp optimizations
Summary:
I had a bit of trouble with this stack of diffs because the names here were sometimes inconsistent and/or long. This diff is simply a renaming that calls everything associated with this optimization "StaticMultiProp...". The values are the StaticMultiPropValues; the (link, count) pair is the StaticMultiPropCache.
We also add const and mutable accessors for this data, which is a bit safer than const-casting, as it is additionally restricted by the const-ness of the Class itself. That catches the fact that initSPropHandles is supposedly a const operation, which is perhaps a little strange? (To be fair, it doesn't edit any of the class's properties, only editing through pointers.)
Since this diff is just about naming, please let me know if some other names would be clearer!
Reviewed By: oulgen
Differential Revision: D25742738
fbshipit-source-id: 99bcfd6dd1b603c4939509a52abbc4a0da6fffe4
Summary:
I had a bit of trouble with this stack of diffs because the names here were sometimes inconsistent and/or long. This diff is simply a renaming that calls everything associated with this optimization "StaticMultiProp...". The values are the StaticMultiPropValues; the (link, count) pair is the StaticMultiPropCache.
We also add const and mutable accessors for this data, which is a bit safer than const-casting, as it is additionally restricted by the const-ness of the Class itself. That catches the fact that initSPropHandles is supposedly a const operation, which is perhaps a little strange? (To be fair, it doesn't edit any of the class's properties, only editing through pointers.)
Since this diff is just about naming, please let me know if some other names would be clearer!
Reviewed By: oulgen
Differential Revision: D25742738
fbshipit-source-id: 99bcfd6dd1b603c4939509a52abbc4a0da6fffe4
| hphp/runtime/vm/class.cpp | diffblobblamehistory | |
| hphp/runtime/vm/class.h | diffblobblamehistory |