| commit | 0ceb0b7ce43330cd9dbbe4d87565f3784c7c1c0c | |
| author | Andrew Kennedy <[email protected]> | |
| Sat, 4 Feb 2023 00:50:34 +0000 (3 16:50 -0800) | ||
| committer | Facebook GitHub Bot <[email protected]> | |
| Sat, 4 Feb 2023 00:50:34 +0000 (3 16:50 -0800) | ||
| tree | 1cbfd0889e9497c8c695ac696b45d7a1157ccd6f | treesnapshot (tar.gz zip) |
| parent | 0dafebf9479ae4818c294f50eef444691740a0e5 | commitdiff |
Remove redundant RequireDynamic]
Summary: For generic types under Sound Dynamic we have a range of options. One is the use of `__RequireDynamic` on generic parameters, which means that the generic type is dynamic-aware subtype of `dynamic` only if the parameter is *exactly* `dynamic`. This is not appropriate for a uniform pessimisation policy, because `Vector<string>` and similar then do not support dynamic. It was a mistake to put these on generics in `hhi` - let's remove them.
Reviewed By: periodic1236
Differential Revision: D43003832
fbshipit-source-id: abe0c321a821c56a15df36e6c1b99a2160186547
Summary: For generic types under Sound Dynamic we have a range of options. One is the use of `__RequireDynamic` on generic parameters, which means that the generic type is dynamic-aware subtype of `dynamic` only if the parameter is *exactly* `dynamic`. This is not appropriate for a uniform pessimisation policy, because `Vector<string>` and similar then do not support dynamic. It was a mistake to put these on generics in `hhi` - let's remove them.
Reviewed By: periodic1236
Differential Revision: D43003832
fbshipit-source-id: abe0c321a821c56a15df36e6c1b99a2160186547
49 files changed: