| commit | 0c653797e4653b273aa8d2d52aab1366b7e614d4 | |
| author | Jan Oravec <[email protected]> | |
| Fri, 28 Aug 2020 00:53:39 +0000 (27 17:53 -0700) | ||
| committer | Facebook GitHub Bot <[email protected]> | |
| Fri, 28 Aug 2020 00:55:42 +0000 (27 17:55 -0700) | ||
| tree | 1367e2f73ecc3f2bcc5fc259d2c08b735f61bde0 | treesnapshot (tar.gz zip) |
| parent | f2a2a1abadc66a4b3343eb8f23ec66ed7afab30e | commitdiff |
Remove no longer used CallUnpack logic
Summary:
The previous implementation dealt with unpack arguments by spilling the ActRec
and invoking doFCall(). This is slow and makes it hard to refactor doFCall().
Highlights:
- unpack no longer returns via retHelper
- removes a usage of funcBodyHelper; there's only one left
- removes the last place where we load Func from ActRec in JIT (unblocks m_func -> m_funcId)
- kills doFCallUnpack, eliminating a weird place to go from JIT to interp
- the above should help eliminate necessity to read ActRec::m_numArgs
Reviewed By: ricklavoie, oulgen
Differential Revision: D23339074
fbshipit-source-id: 0cf244b5ce4d4eb691bab4a31a121d70ffb14ee4
Summary:
The previous implementation dealt with unpack arguments by spilling the ActRec
and invoking doFCall(). This is slow and makes it hard to refactor doFCall().
Highlights:
- unpack no longer returns via retHelper
- removes a usage of funcBodyHelper; there's only one left
- removes the last place where we load Func from ActRec in JIT (unblocks m_func -> m_funcId)
- kills doFCallUnpack, eliminating a weird place to go from JIT to interp
- the above should help eliminate necessity to read ActRec::m_numArgs
Reviewed By: ricklavoie, oulgen
Differential Revision: D23339074
fbshipit-source-id: 0cf244b5ce4d4eb691bab4a31a121d70ffb14ee4
27 files changed: