| commit | 04a15da417881a18c43b5967a6137e9ab29a307b | |
| author | Tatiana Racheva <[email protected]> | |
| Thu, 5 Sep 2019 00:08:29 +0000 (4 17:08 -0700) | ||
| committer | Hhvm Bot <[email protected]> | |
| Thu, 5 Sep 2019 00:14:27 +0000 (4 17:14 -0700) | ||
| tree | 86df9cf02950101c9af7cb079b193218d397c9d7 | treesnapshot (tar.gz zip) |
| parent | a6e682144e53979a5bad5b8f7005773074978ad8 | commitdiff |
Make default Eden threshold value optional
Summary:
Just to remove some confusion (mainly, my own), I'm making the remote scheduler env's Eden threshold an optional type, to distinguish it from being set to a specific value by the caller.
In the remote scheduler, the threshold is used to determine if the remote worker's checkout should be backed by Eden or not. It's backed by Eden if the number of files to type check is fewer than the threshold.
Note that I flipped the comparison and it's not identical, but it's more correct now, anyway (the behavior changes AT the threshold, not above it).
Differential Revision: D17186170
fbshipit-source-id: 123c940b02ae3d94f79ac1d431150352662fdb73
Summary:
Just to remove some confusion (mainly, my own), I'm making the remote scheduler env's Eden threshold an optional type, to distinguish it from being set to a specific value by the caller.
In the remote scheduler, the threshold is used to determine if the remote worker's checkout should be backed by Eden or not. It's backed by Eden if the number of files to type check is fewer than the threshold.
Note that I flipped the comparison and it's not identical, but it's more correct now, anyway (the behavior changes AT the threshold, not above it).
Differential Revision: D17186170
fbshipit-source-id: 123c940b02ae3d94f79ac1d431150352662fdb73
| hphp/hack/src/stubs/remoteScheduler.ml | diffblobblamehistory | |
| hphp/hack/src/typing/typing_remote_check_service.ml | diffblobblamehistory |