- Look for anti-patterns.
- Lint the code if it has not already been done.
- If something looks really strange, talk to the developer before proceeding--maybe they are not ready to have their pull request examined.
- Look for hard-coded values that could have been put into environment variables, arguments, or some kind of config file.
- Look for security issues (eg: hardcoded passwords, keys in the repo, opportunities for SQL injection attacks, etc).
- Look for functions that could have been made more generic and reusable.
- Look for silly custom code that does something that a built-in language feature does better.
- Check any comments and ensure they make sense.
- When referring to someone else's code, be sure to just say "this code" or "the code", rather than "your code"; it's just better etiquette.
mikequentel
- 544
- 3
- 6