Timeline for Does my class violate the Single-Responsibility Principle?
Current License: CC BY-SA 4.0
7 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Jan 11, 2023 at 10:08 | comment | added | Ewan | you really, dont. but if you insist then you should move it out to its own, ratecalc class and inject that | |
| Jan 11, 2023 at 9:21 | comment | added | tail | I have to, since its behavior depends on many subclasses! | |
| Jan 10, 2023 at 20:23 | comment | added | Ewan | dont override it | |
| Jan 10, 2023 at 18:35 | comment | added | tail | AbstractItem.getRate() cannot be private since it gets overridden | |
| Jan 10, 2023 at 18:31 | comment | added | Ewan | base class has the same issue, rate doesnt need to be public | |
| Jan 10, 2023 at 18:01 | comment | added | tail | Cannot make it private since it overrides a public method from its base class. | |
| Jan 9, 2023 at 13:38 | history | answered | Ewan | CC BY-SA 4.0 |