Skip to main content
Software Engineering

You are not logged in. Your edit will be placed in a queue until it is peer reviewed.

We welcome edits that make the post easier to understand and more valuable for readers. Because community members review edits, please try to make the post substantially better than how you found it, for example, by fixing grammar or adding additional resources and hyperlinks.

15
  • 11
    I think this question should be directed at the developers of the library in question. Commented Sep 2, 2021 at 18:11
  • 35
    It doesn't have to be answered specific to this library. It's a general enough question, even though it cites a narrow example. Commented Sep 2, 2021 at 18:18
  • 8
    In this specific case, with a default option you will either have a memory leak, or silently break certain use cases. "true" is the safer option, since it will close the resource automatically. But "true" will not work if the stream is processed by other functions further down the line, without the IMessage-Object. e.g. asynchronous processing, caching and such things. In these cases you have to specify "false" and make sure the resource is closed at the right time to prevent a memory leak. Commented Sep 3, 2021 at 11:38
  • 59
    Note that the authors of the library followed semantic versioning principles and changed their Major Version number, which generally indicates breaking changes may occur. I always consider that before upgrading any library, no matter how numb I am. Commented Sep 3, 2021 at 14:23
  • 13
    Having breaking changes is literally the definition of a Major Version Change. Commented Sep 3, 2021 at 21:56