Skip to main content
Software Engineering

You are not logged in. Your edit will be placed in a queue until it is peer reviewed.

We welcome edits that make the post easier to understand and more valuable for readers. Because community members review edits, please try to make the post substantially better than how you found it, for example, by fixing grammar or adding additional resources and hyperlinks.

Required fields*

18
  • 21
    A code sample people find confusing would be quite helpful. Commented Jun 17, 2020 at 5:15
  • 10
    Also, what sort of code are you writing? Code that is difficult to understand because it's applying a Heisenberg crossover compensation on the subspace plasma relay is going to have a different set of challenges than code that is difficult to understand because it uses esotheric language features or non-idiomatic code for more ordinary situations. Commented Jun 17, 2020 at 5:22
  • 12
    "Always code as if the person who ends up maintaining your code is a violent psychopath who knows where you live." Commented Jun 17, 2020 at 5:57
  • 7
    I have never used TypeScript for anything, but by analogy with many other languages your original code sample is perfectly clear and understandable. On the other hand your "improved" version is, bluntly, an obfuscated incomprehensible mess. If I was your team leader and you did that more than once, you would be looking for other employment. Hiring a replacement is often easier than trying to convert someone who might be a genius, or might be a fool, into a useful team player. Commented Jun 17, 2020 at 21:13
  • 6
    Your code is more complicated than the brain-dead original, but not that complicated. I wonder if maybe your colleagues' confusion could be about what you are trying to solve (i.e. they don't feel the pain you are treating) rather than what your code actually does? But at the same time, I also wonder if they may be right - how many brain-dead reducers do you really have, how often do they change in ways your code would help with? Commented Jun 29, 2020 at 18:14