You are not logged in. Your edit will be placed in a queue until it is peer reviewed.
We welcome edits that make the post easier to understand and more valuable for readers. Because community members review edits, please try to make the post substantially better than how you found it, for example, by fixing grammar or adding additional resources and hyperlinks.
-
You said that keeping the state variables shared among class functions is fine. Let's for a second not create any dispatcher. These state variables are set and reset by class functions. There are no public getters and setters as we don't want other classes to get these variables. I think unit testing in this case would be difficult.Navjot Singh– Navjot Singh2020-03-18 10:23:24 +00:00Commented Mar 18, 2020 at 10:23
-
@NavjotSingh: A dispatcher would be appropriate for stuff like this; it wouldn't be surprising if a lack of a dispatcher would enable undue complexity in, e.g., unit tests. To be clear: the sharing of a mutable entity isn't problematic, but having scattered logics interacting with it could be.Nat– Nat2020-03-18 10:31:04 +00:00Commented Mar 18, 2020 at 10:31
-
Yes, scattered logic makes the code ugly and hard to read. Although I have to still wrap my head around this dispatcher as well.Navjot Singh– Navjot Singh2020-03-18 10:32:38 +00:00Commented Mar 18, 2020 at 10:32
-
@NavjotSingh: Just to check: are you familiar with multi-threaded programming and issues like race conditions? For example, do you understand the issue asked about in this question?Nat– Nat2020-03-18 10:43:32 +00:00Commented Mar 18, 2020 at 10:43
-
to be honest I asked the question in a general sense giving an example which involved DateTime but there can be other examples as well, like the one for logging which I gave in my question. Yes, I'm familiar with multi-threaded programming but my main aim was to look for a better design.Navjot Singh– Navjot Singh2020-03-19 08:09:35 +00:00Commented Mar 19, 2020 at 8:09
Add a comment
|
How to Edit
- Correct minor typos or mistakes
- Clarify meaning without changing it
- Add related resources or links
- Always respect the author’s intent
- Don’t use edits to reply to the author
How to Format
-
create code fences with backticks ` or tildes ~
```
like so
``` -
add language identifier to highlight code
```python
def function(foo):
print(foo)
``` - put returns between paragraphs
- for linebreak add 2 spaces at end
- _italic_ or **bold**
- indent code by 4 spaces
- backtick escapes
`like _so_` - quote by placing > at start of line
- to make links (use https whenever possible)
<https://example.com>[example](https://example.com)<a href="https://example.com">example</a>
How to Tag
A tag is a keyword or label that categorizes your question with other, similar questions. Choose one or more (up to 5) tags that will help answerers to find and interpret your question.
- complete the sentence: my question is about...
- use tags that describe things or concepts that are essential, not incidental to your question
- favor using existing popular tags
- read the descriptions that appear below the tag
If your question is primarily about a topic for which you can't find a tag:
- combine multiple words into single-words with hyphens (e.g. design-patterns), up to a maximum of 35 characters
- creating new tags is a privilege; if you can't yet create a tag you need, then post this question without it, then ask the community to create it for you