You are not logged in. Your edit will be placed in a queue until it is peer reviewed.
We welcome edits that make the post easier to understand and more valuable for readers. Because community members review edits, please try to make the post substantially better than how you found it, for example, by fixing grammar or adding additional resources and hyperlinks.
-
Regardless of the commit and the Boy Scout rule consider that this is a breaking change to a public interface. You will need to refactor everything that calls this.candied_orange– candied_orange2018-12-17 13:37:41 +00:00Commented Dec 17, 2018 at 13:37
-
1Are you not allowed to use the same Jira for multiple commits?Karl Bielefeldt– Karl Bielefeldt2018-12-17 14:26:41 +00:00Commented Dec 17, 2018 at 14:26
-
@candied_orange It is not a public function. That is actually in objective-c in an internal header file.findusl– findusl2018-12-17 14:28:53 +00:00Commented Dec 17, 2018 at 14:28
-
@Karl Bielefeldt I can. But per Jira Task I can only do one request for 'merging' my branch into the master. (I would also prefer develop branch but that is another thing). And there somebody code reviews and sees the changes from all the commits.findusl– findusl2018-12-17 14:30:14 +00:00Commented Dec 17, 2018 at 14:30
Add a comment
|
How to Edit
- Correct minor typos or mistakes
- Clarify meaning without changing it
- Add related resources or links
- Always respect the author’s intent
- Don’t use edits to reply to the author
How to Format
-
create code fences with backticks ` or tildes ~
```
like so
``` -
add language identifier to highlight code
```python
def function(foo):
print(foo)
``` - put returns between paragraphs
- for linebreak add 2 spaces at end
- _italic_ or **bold**
- indent code by 4 spaces
- backtick escapes
`like _so_` - quote by placing > at start of line
- to make links (use https whenever possible)
<https://example.com>[example](https://example.com)<a href="https://example.com">example</a>
How to Tag
A tag is a keyword or label that categorizes your question with other, similar questions. Choose one or more (up to 5) tags that will help answerers to find and interpret your question.
- complete the sentence: my question is about...
- use tags that describe things or concepts that are essential, not incidental to your question
- favor using existing popular tags
- read the descriptions that appear below the tag
If your question is primarily about a topic for which you can't find a tag:
- combine multiple words into single-words with hyphens (e.g. design-patterns), up to a maximum of 35 characters
- creating new tags is a privilege; if you can't yet create a tag you need, then post this question without it, then ask the community to create it for you