Edit - Software Engineering Stack Exchange

You are not logged in. Your edit will be placed in a queue until it is peer reviewed.

We welcome edits that make the post easier to understand and more valuable for readers. Because community members review edits, please try to make the post substantially better than how you found it, for example, by fixing grammar or adding additional resources and hyperlinks.

Care to specify why encouraging the initial author to merge their own pull requests would build a sense of ownership? I believe in collective ownership and consider open PRs as statements of shared ownership between initial author and reviewers/community. I respect your opinion, would like to hear more about how the control over who hits merge translates to sense of ownership. Being able to open a pr and have others review and discuss already brings enough ownership, but I had another person tell me about ownership the same way you did, so I would like to understand that point.

leosteffen
– leosteffen

2021-03-03 17:49:21 +00:00
Commented Mar 3, 2021 at 17:49
6

@leosteffen in a team project, ownership is shared and collective. By definition. I'm not calling this into question. The author of a given PR knows their PR better than anybody else; even if they provide a great PR description, as they should, the consequences of merging the PR cannot typically be clearer and more comprehensive to other contributors. By merging your own PR, you know exactly when it lands into master (now, main) and you take responsibility for it from start to finish.

mkcor
– mkcor

2021-04-23 21:40:52 +00:00
Commented Apr 23, 2021 at 21:40

Add a comment |

Correct minor typos or mistakes
Clarify meaning without changing it
Add related resources or links
Always respect the author’s intent
Don’t use edits to reply to the author

create code fences with backticks ` or tildes ~
```
like so
```
add language identifier to highlight code
```python
def function(foo):
print(foo)
```
put returns between paragraphs
for linebreak add 2 spaces at end
_italic_ or **bold**
indent code by 4 spaces
backtick escapes `like _so_`
quote by placing > at start of line
to make links (use https whenever possible)

<https://example.com>

[example](https://example.com)

<a href="https://example.com">example</a>

formatting help »
answering help »